ZEND_ASYNC_IO_PRESERVE_FD carried no prose, and its real contract turned out to be narrower than every caller assumed: it reaches only a descriptor the reactor closes on its own account. A descriptor adopted by a libuv stream handle is outside it — the handle owns the descriptor and uv_close closes it whatever the flag says.
That gap cost a real defect in true-async/server (issue php#293): a log sink passed the flag for a TCP socket, kept the PHP stream on the strength of it, and the socket was closed twice — WSAENOTSOCK on Windows, a silent EBADF on POSIX, which is the worse half because the descriptor number is reused and the late close lands on another connection.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZEND_ASYNC_IO_PRESERVE_FD carried no prose, and its real contract turned out to be narrower than every caller assumed: it reaches only a descriptor the reactor closes on its own account. A descriptor adopted by a libuv stream handle is outside it — the handle owns the descriptor and uv_close closes it whatever the flag says.
That gap cost a real defect in true-async/server (issue php#293): a log sink passed the flag for a TCP socket, kept the PHP stream on the strength of it, and the socket was closed twice — WSAENOTSOCK on Windows, a silent EBADF on POSIX, which is the worse half because the descriptor number is reused and the late close lands on another connection.
Header comment only, no behaviour change.