feat(cache): add explicit auto output tracking - #460
Conversation
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a1c7046148
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
| &mut negative_globs, | ||
| )?; | ||
| } | ||
| UserOutputEntry::Auto(AutoInput { auto: true }) => includes_auto = true, |
There was a problem hiding this comment.
Propagate auto outputs through synthetic cache merges
When an inherited SyntheticPlanRequest supplies output: [{ auto: true }], this new includes_auto value is resolved here but resolve_synthetic_cache_config still merges only positive_globs and negative_globs from synthetic_output (crates/vite_task_plan/src/plan.rs:521-535). In that nested-synthetic context the flag is dropped back to the parent output config (usually false), so fspy is not attached and the synthetic command's written outputs are never archived or restored despite opting into auto output tracking.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
Merge activity |
Sorry, something went wrong.
Co-authored-by: GPT-5 Codex <codex@openai.com>
Motivation
Users should be able to ask the runner to archive files written by a task without manually maintaining output globs, while still keeping the default behavior unchanged for a small reviewable step.
Scope
Support output: [{ auto: true }], attach fspy when explicit auto output tracking is requested, keep read and write filtering separate, and archive fspy-tracked writes after applying output negatives and runner ignoreOutput reports. Add an e2e with input: [] to prove explicit auto output tracking works on its own.