feat(client): serve getEnvs over runner IPC - #449
Merged
wan9chi merged 1 commit intoJun 14, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This was referenced Jun 13, 2026
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
This was referenced Jun 13, 2026
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
2f508b0 to
e078bf2
Compare
June 13, 2026 11:11
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
2 times, most recently
from
51a8c0c to
ce0d262
Compare
June 13, 2026 14:22
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
2 times, most recently
from
6e58a88 to
01ea610
Compare
June 13, 2026 14:27
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
2 times, most recently
from
93cfb02 to
b77c960
Compare
June 13, 2026 14:37
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
01ea610 to
399692e
Compare
June 13, 2026 14:37
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
from
b77c960 to
aef9617
Compare
June 13, 2026 15:58
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
399692e to
25a3219
Compare
June 13, 2026 15:58
wan9chi
marked this pull request as ready for review
June 13, 2026 15:59
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
from
aef9617 to
fee0f27
Compare
June 13, 2026 16:01
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
25a3219 to
97aa3f0
Compare
June 13, 2026 16:01
Copy link
Copy Markdown
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 25a3219ef2
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
Comment thread
crates/vite_task_server/src/lib.rs
Outdated
Comment thread
crates/vite_task_client_napi/src/lib.rs
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
from
fee0f27 to
67b6aa2
Compare
June 13, 2026 16:03
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
97aa3f0 to
32ac35f
Compare
June 13, 2026 16:03
wan9chi
force-pushed
the
infra-get-env-fingerprint
branch
from
67b6aa2 to
f61eaac
Compare
June 13, 2026 16:09
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
32ac35f to
ae0eb9d
Compare
June 13, 2026 16:09
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
ae0eb9d to
de59cd5
Compare
June 13, 2026 17:18
wan9chi
force-pushed
the
graphite-base/449
branch
from
0cae90a to
fb19a12
Compare
June 14, 2026 08:48
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
930e359 to
21b2fc2
Compare
June 14, 2026 08:48
wan9chi
changed the base branch from
graphite-base/449
to
infra-get-env-tracked-option
June 14, 2026 08:48
wan9chi
changed the base branch from
infra-get-env-tracked-option
to
graphite-base/449
June 14, 2026 09:13
wan9chi
force-pushed
the
graphite-base/449
branch
from
fb19a12 to
b319c60
Compare
June 14, 2026 09:13
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
21b2fc2 to
05ac2d2
Compare
June 14, 2026 09:13
wan9chi
force-pushed
the
graphite-base/449
branch
from
b319c60 to
ded4204
Compare
June 14, 2026 09:49
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
05ac2d2 to
a25bdcd
Compare
June 14, 2026 09:49
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
a25bdcd to
2ad156b
Compare
June 14, 2026 10:03
wan9chi
force-pushed
the
graphite-base/449
branch
from
ded4204 to
34a7ac1
Compare
June 14, 2026 10:03
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
2ad156b to
b54a4e1
Compare
June 14, 2026 10:08
wan9chi
force-pushed
the
graphite-base/449
branch
from
34a7ac1 to
377cc3d
Compare
June 14, 2026 10:08
Motivation: Tools need a bulk env read path for APIs like Vite loadEnv that discover an env prefix rather than a single name. Before this change, getEnvs existed on the JS surface but always returned an empty match set. Scope: Add the GetEnvs request/response frame, Rust client support, NAPI getEnvs implementation, server-side env glob matching, invalid-glob error surfacing, and print-only e2e coverage. This PR intentionally does not add getEnvs match sets to cache fingerprints. Verification: - cargo test -p vite_task_server --test integration - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_envs_reads_match_set -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_envs_reads_match_set -- --ignored
wan9chi
force-pushed
the
infra-get-envs-ipc
branch
from
b54a4e1 to
3752763
Compare
June 14, 2026 10:08
Copy link
Copy Markdown
Member
Author
Merge activity |
Sorry, something went wrong.
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Tools need a bulk env read path for APIs like Vite loadEnv, which discover envs by prefix rather than by a single name. Before this slice, getEnvs existed on the JS surface but returned an empty match set.
Scope
Add the GetEnvs protocol frame, Rust client support, NAPI getEnvs implementation, server-side env glob matching, invalid-glob error surfacing, and print-only e2e coverage. The NAPI boundary now errors if a matched env name or value cannot be represented as UTF-8 instead of silently dropping it.
This PR intentionally does not add getEnvs match sets to cache fingerprints and does not add the tracked option. Those are later PRs in the stack.
Verification