feat(cache): fingerprint tracked getEnv reads by wan9chi · Pull Request #448 · voidzero-dev/vite-task · GitHub

Motivation

Once tools can read env values from the runner, cached tasks must remember tracked getEnv reads. Otherwise a later run can replay stale output after a tracked env value changes.

Scope

Make the getEnv tracked option meaningful, record served single-env values in IPC reports, store tracked values in the post-run fingerprint, validate them during cache lookup, and render env-specific cache miss messages. This PR intentionally does not implement getEnvs or env glob match-set tracking.

Verification

cargo test -p vite_task_server --test integration
UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored
UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored
cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored
cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored

This stack of pull requests is managed by Graphite. Learn more about stacking.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: aef96174a2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Redact tracked env values before caching

When a runner-aware tool reads a secret such as GITHUB_TOKEN/NPM_TOKEN with the default tracked: true, this stores the raw value in the serialized PostRunFingerprint; on a later change SavedCacheMissReason::TrackedEnvChanged formats the same EnvMismatch, so old/new secret values can be persisted in the cache DB and emitted in the full task summary. Declared env fingerprinting hashes sensitive patterns in EnvFingerprints::resolve, but this new path bypasses that protection, so tracked envs should be hashed/redacted before storage/display.

Useful? React with 👍 / 👎.

Motivation: Once tools can read env values from the runner, cached tasks must remember tracked getEnv reads or a later run can replay stale output after the env changes. Scope: Make the getEnv tracked option meaningful, record served single-env values in IPC reports, store tracked getEnv values in the post-run fingerprint, validate them during cache lookup, and render env-specific cache miss messages. This PR intentionally does not implement getEnvs or env glob match-set tracking. Verification: - cargo test -p vite_task_server --test integration - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored

Merge activity

Jun 14, 2:38 AM UTC: A user started a stack merge that includes this pull request via Graphite.
Jun 14, 2:38 AM UTC: @wan9chi merged this pull request with Graphite.

Motivation: Revert the accidental merge of #448 so the tracked getEnv fingerprinting change can return as a normal reviewed PR instead of being landed out of order. Scope: This is a mechanical revert of the #448 squash commit (`2055bb0c`). It removes the tracked getEnv fingerprinting implementation and e2e coverage that #448 introduced, returning `main` to the #447 state. Verification: - CI

wan9chi force-pushed the infra-get-env-fingerprint branch from 5e3b5ec to 51a8c0c Compare June 13, 2026 11:11

wan9chi force-pushed the infra-get-env-prefix-context branch 2 times, most recently from 29db327 to e9111bd Compare June 13, 2026 14:22

wan9chi force-pushed the infra-get-env-fingerprint branch 2 times, most recently from ce0d262 to 93cfb02 Compare June 13, 2026 14:27

wan9chi force-pushed the infra-get-env-prefix-context branch 2 times, most recently from 97761ba to 4b74a2c Compare June 13, 2026 14:36

wan9chi force-pushed the infra-get-env-fingerprint branch from 93cfb02 to b77c960 Compare June 13, 2026 14:37

wan9chi force-pushed the infra-get-env-prefix-context branch from 4b74a2c to c45b304 Compare June 13, 2026 15:58

wan9chi force-pushed the infra-get-env-fingerprint branch from b77c960 to aef9617 Compare June 13, 2026 15:58

wan9chi marked this pull request as ready for review June 13, 2026 15:59

wan9chi force-pushed the infra-get-env-prefix-context branch from c45b304 to b96d1bd Compare June 13, 2026 16:01

wan9chi force-pushed the infra-get-env-fingerprint branch from aef9617 to fee0f27 Compare June 13, 2026 16:01

wan9chi force-pushed the infra-get-env-prefix-context branch from b96d1bd to b3d0921 Compare June 13, 2026 16:03

wan9chi force-pushed the infra-get-env-fingerprint branch from fee0f27 to 67b6aa2 Compare June 13, 2026 16:03

chatgpt-codex-connector Bot reviewed Jun 13, 2026

View reviewed changes

wan9chi force-pushed the infra-get-env-prefix-context branch 2 times, most recently from 83684b7 to 3dcd916 Compare June 13, 2026 16:09

wan9chi force-pushed the infra-get-env-fingerprint branch from 67b6aa2 to f61eaac Compare June 13, 2026 16:09

wan9chi changed the base branch from infra-get-env-prefix-context to graphite-base/448 June 13, 2026 17:16

wan9chi mentioned this pull request Jun 13, 2026

refactor(plan): rename spawn env map #452

Merged

wan9chi force-pushed the infra-get-env-fingerprint branch from f61eaac to 8d340a9 Compare June 13, 2026 17:18

wan9chi force-pushed the graphite-base/448 branch from 3dcd916 to eac9b11 Compare June 13, 2026 17:18

wan9chi changed the base branch from graphite-base/448 to infra-get-env-prefix-context June 13, 2026 17:18

wan9chi force-pushed the infra-get-env-prefix-context branch 2 times, most recently from 0a8737d to f19e16c Compare June 13, 2026 17:22

wan9chi force-pushed the infra-get-env-fingerprint branch from 8d340a9 to be64c57 Compare June 13, 2026 17:22

wan9chi changed the base branch from infra-get-env-prefix-context to graphite-base/448 June 13, 2026 17:22

graphite-app Bot changed the base branch from graphite-base/448 to infra-get-env-prefix-context June 13, 2026 17:23

wan9chi force-pushed the infra-get-env-fingerprint branch from be64c57 to 136a98b Compare June 13, 2026 17:27

wan9chi changed the base branch from infra-get-env-prefix-context to graphite-base/448 June 13, 2026 17:43

wan9chi force-pushed the infra-get-env-fingerprint branch from 136a98b to 7a67801 Compare June 13, 2026 17:44

wan9chi force-pushed the graphite-base/448 branch from 7bf34a6 to feb640c Compare June 13, 2026 17:44

wan9chi changed the base branch from graphite-base/448 to infra-get-env-prefix-context June 13, 2026 17:44

wan9chi changed the base branch from infra-get-env-prefix-context to graphite-base/448 June 14, 2026 02:21

wan9chi force-pushed the graphite-base/448 branch from feb640c to 700c46a Compare June 14, 2026 02:31

wan9chi force-pushed the infra-get-env-fingerprint branch from 7a67801 to 08b48f2 Compare June 14, 2026 02:31

wan9chi changed the base branch from graphite-base/448 to main June 14, 2026 02:31

wan9chi merged commit 2055bb0 into main Jun 14, 2026
20 of 29 checks passed

wan9chi deleted the infra-get-env-fingerprint branch June 14, 2026 02:38

wan9chi mentioned this pull request Jun 14, 2026

revert(cache): revert tracked getEnv fingerprint #453

Merged

feat(cache): fingerprint tracked getEnv reads by wan9chi · Pull Request #448 · voidzero-dev/vite-task · GitHub

Uh oh!

feat(cache): fingerprint tracked getEnv reads - #448

feat(cache): fingerprint tracked getEnv reads#448
wan9chi merged 1 commit into
mainfrom
infra-get-env-fingerprint

wan9chi commented Jun 13, 2026 •
edited
Loading

Uh oh!

Uh oh!

wan9chi commented Jun 13, 2026 •
edited
Loading

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Jun 13, 2026

Uh oh!

wan9chi commented Jun 14, 2026 •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

+                          if fingerprinted.contains_key(name_str) {
+                              return None;
+                          }
+                          let value = record.value.as_ref().and_then(|value| value.to_str().map(Str::from));

feat(cache): fingerprint tracked getEnv reads by wan9chi · Pull Request #448 · voidzero-dev/vite-task · GitHub

Uh oh!

feat(cache): fingerprint tracked getEnv reads - #448

feat(cache): fingerprint tracked getEnv reads#448wan9chi merged 1 commit intomainvoidzero-dev/vite-task:mainfrom infra-get-env-fingerprintvoidzero-dev/vite-task:infra-get-env-fingerprintCopy head branch name to clipboard

Conversation

wan9chi commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Scope

Verification

Uh oh!

wan9chi commented Jun 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Jun 13, 2026

Choose a reason for hiding this comment

Uh oh!

wan9chi commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

feat(cache): fingerprint tracked getEnv reads#448
wan9chi merged 1 commit into
mainfrom
infra-get-env-fingerprint

wan9chi commented Jun 13, 2026 •
edited
Loading

wan9chi commented Jun 13, 2026 •
edited
Loading

wan9chi commented Jun 14, 2026 •
edited
Loading