| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Sorry, something went wrong.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Sorry, something went wrong.
Add the runner-aware IPC protocol, embedded Node client addon, execution-time server lifecycle, and disableCache handling. The protocol ships with the single disableCache verb; getEnv/getEnvs land with env tracking (#430) and ignoreInput/ignoreOutput with auto output tracking (#431), each alongside the runner logic that consumes them. Co-Authored-By: OpenAI <codex@openai.com>
Merge activity |
Sorry, something went wrong.
Serve real env values over the IPC channel (#441) and make them part of cache correctness: - The server resolves `getEnv`/`getEnvs` against an env map and records the served values and glob match-sets. - The post-run fingerprint stores tracked envs and glob match-sets; cache lookup re-validates them and reports the changed env by name (wording matches manual `env` config misses). - `CACHE_SCHEMA_VERSION` bumps to 14: `PostRunFingerprint` gains fields, so the serialized cache value layout changes and must not share a schema directory with binaries built before this change. - `ignoreInput`/`ignoreOutput` stay accepted-but-no-op — they land with auto output tracking. - Auto output restoration stays disabled: `output: None` resolves to a disabled glob config (matching prior behavior), so a cache hit replays recorded output without restoring written files. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Here are some automated review suggestions for this pull request.
Reviewed commit: 3277d1cfb1
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Sorry, something went wrong.
| // Resolve input negative globs for fspy path filtering (already | ||
| // workspace-root-relative). | ||
| let fspy_negatives = if metadata.input_config.includes_auto { | ||
| let tracking = if metadata.input_config.includes_auto { |
There was a problem hiding this comment.
Enable IPC for explicit-input cached tasks
When a cached task configures input without { "auto": true } (for example to avoid fspy and use explicit globs), this gate never starts the IPC server, and injected_envs() therefore also omits VP_RUN_NODE_CLIENT_PATH. The JS client treats that as outside the runner and disableCache() becomes a no-op, so dev/watch tools that explicitly opt out are still cached and replayed on the next run. The IPC channel needs to be available for all cacheable executions, not only auto-input tracking.
Useful? React with 👍 / 👎.
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Motivation
Runner-aware tools need a small, reliable way to tell the task runner when a run must not be cached. Dev-server style workflows are the clearest example: they may run successfully but intentionally do not produce a deterministic cacheable result. This PR lands the IPC channel with the one cache-affecting verb that is safe on its own: disableCache().
The IPC internals are deliberately minimal: protocol, sync client, and server ship only the disableCache verb. The Node addon, however, exposes the full client surface from day one — ignoreInput/ignoreOutput/getEnv/getEnvs exist as documented no-ops — because the npm-published JS wrapper calls these methods unconditionally, and a stable addon surface lets real tools (vite) run end-to-end at every PR in this stack. Each no-op becomes a real IPC request in the PR that adds the runner logic consuming it: env verbs in #430, ignore verbs in #431.
Review focus
Verification
Draft while the stack is under review.
🤖 Generated with Claude Code