164 pkcs11 support - #253
Merged
jimjag merged 8 commits intoMar 12, 2024
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
…bxmlsec version available from Python.
tdivis
force-pushed
the
164-pkcs11-support
branch
7 times, most recently
from
b23ab3c to
0b5939f
Compare
April 17, 2023 11:55
ayakael
reviewed
Jan 14, 2024
Comment thread
src/keys.c
| if ((key = PyXmlSec_NewKey1((PyTypeObject*)self)) == NULL) goto ON_FAIL; | ||
|
|
||
| Py_BEGIN_ALLOW_THREADS; | ||
| key->handle = xmlSecCryptoAppKeyLoad(engine_and_key_id, xmlSecKeyDataFormatEngine, NULL, xmlSecCryptoAppGetDefaultPwdCallback(), |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
A note with xmlsec 1.3.3, xmlSecCryptoAppKeyLoad is deprecated in favor of xmlSecCryptoAppKeyLoadEx. This added an argument which adds the capacity to handle public keys. Since we're handling a private key, I think that this line should be this:
key->handle = xmlSecCryptoAppKeyLoad(engine_and_key_id, xmlSecKeyDataTypePrivate, xmlSecKeyDataFormatEngine, NULL, xmlSecCryptoAppGetDefaultPwdCallback(),
Sorry, something went wrong.
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #164.
Note: It's based on branch for #164, which should be merged first so the tests pass.