FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Add compatibility with xmlsec 1.3.3 by ayakael · Pull Request #280 · xmlsec/python-xmlsec · GitHub

Add compatibility with xmlsec 1.3.3 - #280

Merged
jimjag merged 2 commits into
xmlsec:masterfrom
ayakael:xmlsec-1.3.3-support
Mar 12, 2024
Merged

Add compatibility with xmlsec 1.3.3#280
jimjag merged 2 commits into
xmlsec:masterfrom
ayakael:xmlsec-1.3.3-support

Conversation

ayakael commented Jan 14, 2024
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #279

ayakael changed the title Add compatability with xmlsec 1.3.3 Add compatibility with xmlsec 1.3.3 Jan 14, 2024

deronnax commented Mar 1, 2024

Copy link
Copy Markdown

@ayakael you linked to a codespace (which can't be accessed). Did you mean #253?

deronnax commented Mar 1, 2024

Copy link
Copy Markdown

for info, and unless I am wrong, #253 which you say you need, introduces another use of xmlSecCryptoAppKeyLoad (the one you commented) but you don't correct it in your PR. So if #253 get merged and then yours, the problem still happens

ayakael commented Mar 1, 2024

Copy link
Copy Markdown
Contributor Author

@deronnax This PR only adjusts the codebase as it is. I already alerted of this issue on #253 . Ideally, the author should update that, but if they don't and it is merged I can adjust this it in this PR.

deronnax commented Mar 4, 2024

Copy link
Copy Markdown

But in the first message of this PR, you say #253 is a requirement for this PR, so when this PR is merged, #253 will have been too, no?

ayakael force-pushed the xmlsec-1.3.3-support branch from 7b57337 to d658b47 Compare March 11, 2024 13:47

ayakael commented Mar 11, 2024

Copy link
Copy Markdown
Contributor Author

But in the first message of this PR, you say #253 is a requirement for this PR, so when this PR is merged, #253 will have been too, no?

It doesn't actually require it. Sorry for the confusion. This PR can be merged as-is.

ayakael mentioned this pull request Mar 11, 2024
ayakael force-pushed the xmlsec-1.3.3-support branch from d658b47 to 7891e71 Compare March 11, 2024 13:57

ayakael commented Mar 11, 2024
edited
Loading

Copy link
Copy Markdown
Contributor Author

I forget a few doc changes that I just pushed now

Copy link
Copy Markdown

@bgaifullin just merging this would fix the current compatibility issue with current libxml, thus fixing python-xmlsec for everyone, and turn the CI back to green. Would you please merge this?

jimjag merged commit a4e135a into xmlsec:master Mar 12, 2024

kloczek commented Mar 25, 2024

Copy link
Copy Markdown

Is it possible to release new version because this PR? 🤔

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

xmlsec 1.3.3 incompatability

4 participants


Back | FazBrowse Home | New Git URL