| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@sakshipatil-hue - you'll need to sign your commits off with DCO |
Sorry, something went wrong.
|
@cmgoffena13 I have amended the commit to include the DCO sign-off and ran the formatting tools to fix the style issues. Could you please approve the workflow run for the latest commit when you get a chance. |
Sorry, something went wrong.
|
@sakshipatil-hue -- way too many changes here, seems like you triggered formatting with different config. |
Sorry, something went wrong.
Signed-off-by: sakshipatil-hue <sakshipatil8674788@gmail.com>
|
Hi @cmgoffena13 , I’ve cleaned up the branch to remove the accidental formatting changes, leaving only the Postgres integration test fix with a proper DCO sign-off. Ready for review whenever you're free! |
Sorry, something went wrong.
|
@sakshipatil-hue -- the ruff format/lint is failing. Make sure you've run make style so its compliant. Look at what files changed too so we don't run into the same issue as before. You can comment on here if you need help. Might be easier to recreate a new branch / PR. The postgres test is failing. Some of the tests are still granting on the old username since its hardcoded. Tests that need adjusted:
Look at test_grants_plan_full_refresh_model_via_replace for an example of how some tests already reference the username correctly |
Sorry, something went wrong.
|
Hi @cmgoffena13, I’ve spun up a clean new PR ([#5990]) with only the necessary test file changes and proper DCO sign-off. Ready for review whenever you have a chance! |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Description
Resolves #5972. Appended a random UUID suffix to the Postgres test user creation logic to ensure parallel integration tests are completely isolated and do not collide.
Test Plan
Ran the test suite locally to ensure the user creation logic executes without syntax errors.
Checklist