FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix(postgres): randomize test_reader username to prevent CI collisions by sakshipatil-hue · Pull Request #5977 · SQLMesh/sqlmesh · GitHub

fix(postgres): randomize test_reader username to prevent CI collisions - #5977

Closed
sakshipatil-hue wants to merge 2 commits into
SQLMesh:mainfrom
sakshipatil-hue:patch-1
Closed

fix(postgres): randomize test_reader username to prevent CI collisions#5977
sakshipatil-hue wants to merge 2 commits into
SQLMesh:mainfrom
sakshipatil-hue:patch-1

Conversation

sakshipatil-hue commented Aug 23, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Resolves #5972. Appended a random UUID suffix to the Postgres test user creation logic to ensure parallel integration tests are completely isolated and do not collide.

Test Plan

Ran the test suite locally to ensure the user creation logic executes without syntax errors.

Checklist

  • I have run make style and fixed any issues
  • I have added tests for my changes (if applicable)
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

cmgoffena13 self-assigned this Aug 23, 2026

Copy link
Copy Markdown
Collaborator

@sakshipatil-hue - you'll need to sign your commits off with DCO

Copy link
Copy Markdown
Contributor Author

@cmgoffena13 I have amended the commit to include the DCO sign-off and ran the formatting tools to fix the style issues. Could you please approve the workflow run for the latest commit when you get a chance.

Copy link
Copy Markdown
Collaborator

@sakshipatil-hue -- way too many changes here, seems like you triggered formatting with different config.

sakshipatil-hue force-pushed the patch-1 branch 2 times, most recently from 1de34a0 to 26f70eb Compare August 26, 2026 06:49
Signed-off-by: sakshipatil-hue <sakshipatil8674788@gmail.com>

Copy link
Copy Markdown
Contributor Author

Hi @cmgoffena13 , I’ve cleaned up the branch to remove the accidental formatting changes, leaving only the Postgres integration test fix with a proper DCO sign-off. Ready for review whenever you're free!

Copy link
Copy Markdown
Collaborator

@sakshipatil-hue -- the ruff format/lint is failing. Make sure you've run make style so its compliant. Look at what files changed too so we don't run into the same issue as before. You can comment on here if you need help. Might be easier to recreate a new branch / PR.

The postgres test is failing. Some of the tests are still granting on the old username since its hardcoded.

Tests that need adjusted:

  • test_grants_plan_target_layer_physical_only
  • test_grants_plan_target_layer_virtual_only

Look at test_grants_plan_full_refresh_model_via_replace for an example of how some tests already reference the username correctly

Copy link
Copy Markdown
Contributor Author

Hi @cmgoffena13, I’ve spun up a clean new PR ([#5990]) with only the necessary test file changes and proper DCO sign-off. Ready for review whenever you have a chance!

Copy link
Copy Markdown
Collaborator

Closing, moved to #5990

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI Fix - Postgres CI Failing Sometimes

2 participants


Back | FazBrowse Home | New Git URL