Harden set-default Checkout in e2e-versions.yml (persist-credentials: false) - #1121
Closed
brunoborges wants to merge 1 commit into
Closed
Harden set-default Checkout in e2e-versions.yml (persist-credentials: false)#1121brunoborges wants to merge 1 commit into
brunoborges wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
… false) The Checkout step in the set-default option job was the only one of 17 checkout steps in the workflow missing persist-credentials: false, flagged by zizmor's artipacked audit. Align it with the rest of the file. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request hardens the setup-java-set-default job in .github/workflows/e2e-versions.yml by aligning its actions/checkout usage with the rest of the workflow: disabling persisted Git credentials to satisfy zizmor’s artipacked audit and reduce credential exposure risk.
Changes:
- Add with: persist-credentials: false to the Checkout step in the setup-java-set-default job.
- Bring the final remaining checkout step in this workflow in line with the other checkout steps already using persist-credentials: false.
| File | Description |
|---|---|
| .github/workflows/e2e-versions.yml | Adds persist-credentials: false to the previously-missing checkout step in the set-default job to close the remaining zizmor hardening gap. |
Review details
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up review of .github/workflows/e2e-versions.yml after the template-injection fixes in #1114 and #1120.
A post-merge Copilot review comment on #1114 noted the "Verify Java 21 outputs are set" step still interpolated step outputs directly in a run: block. That concern was already resolved in #1120, and a full sweep confirms no ${{ ... }} expressions are interpolated directly into any run: block anymore — all step outputs, matrix values, and secrets are routed through step-level env:.
While reviewing, zizmor's artipacked audit flagged one remaining gap: the Checkout step in the set-default option job was the only one of 17 checkout steps in the file missing persist-credentials: false. This PR aligns it with the rest of the file.
After this change, zizmor .github/workflows/e2e-versions.yml reports no findings.
Related
Check list