FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set the node version in package.json by TehShrike · Pull Request #1793 · browserify/browserify · GitHub

/ browserify Public

Set the node version in package.json - #1793

Merged
TehShrike merged 1 commit into
browserify:masterfrom
TehShrike:patch-3
Jan 4, 2018
ConversationCommits (1)ChecksFiles changed
Merged

Set the node version in package.json#1793
TehShrike merged 1 commit into
browserify:masterfrom
TehShrike:patch-3

Conversation

TehShrike commented Jan 4, 2018

Copy link
Copy Markdown
Contributor

Testing against 0.10 and 0.12 was dropped in e8dbe6c

Set the node version in package.json
89fab44 
Testing against 0.10 and 0.12 was dropped in e8dbe6c
TehShrike mentioned this pull request Jan 4, 2018
Closed
goto-bus-stop approved these changes Jan 4, 2018
View reviewed changes

goto-bus-stop left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

good call. would you like to handle the release too?

TehShrike commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

I'm down. 👍

I know that whether or not dropping support for insecure versions of node should be a breaking change is a contentious topic, do you feel this should be a breaking or feature version bump?

Personally I tend towards breaking releases if dropping support for versions of node that are in maintenance, and feature/patch for dropping support for versions of node that are out of LTS, but I don't have strong opinions.

goto-bus-stop commented Jan 4, 2018

Copy link
Copy Markdown
Member

i think we should follow module-deps & detective and do a major bump :)

bcomnes commented Jan 4, 2018

Copy link
Copy Markdown
Member

Just make sure to update module-deps before doing the bump!

TehShrike commented Jan 4, 2018

Copy link
Copy Markdown
Contributor Author

The module-deps dependency got bumped in #1785, so it should be good to go.

Do y'all prefer having pull requests opened for changelog additions, or is it fine if I push changelog+package.json straight into master when publishing?

goto-bus-stop commented Jan 4, 2018

Copy link
Copy Markdown
Member

just pushing straight to master is how i've done it, so i'm cool w/ that!

TehShrike merged commit a9aaa99 into browserify:master Jan 4, 2018
ljharb added a commit to ljharb/browserify that referenced this pull request Jan 6, 2018
Set engines back to 0.8 (reverts browserify#1793)
46410c2
ljharb added a commit to ljharb/browserify that referenced this pull request Jan 7, 2018
Set engines back to 0.8 (reverts browserify#1793)
a522c43
renovate Bot mentioned this pull request May 22, 2021
Open
1 task
This was referenced Jun 1, 2021
Merged
Open
Open
Open
Open
Open
Closed
renovate Bot mentioned this pull request Jun 14, 2021
Merged
1 task
mend-for-github-com Bot mentioned this pull request Jul 5, 2021
Open
1 task
renovate Bot mentioned this pull request Jul 8, 2021
Open
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

goto-bus-stop goto-bus-stop approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL