Response factory as config - #3950
Merged
bbakerman merged 3 commits intoJun 5, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
…to response-factory-as-config
Copy link
Copy Markdown
Contributor
Test Results 318 files ±0 318 suites ±0 2m 32s ⏱️ +2s Results for commit 358c540. ± Comparison against base commit 2b26495. This pull request removes 174 and adds 153 tests. Note that renamed tests count towards both. ?
__schema { types { fields { args { type { name fields { name }}}}}}
__schema { types { fields { type { name fields { name }}}}}
__schema { types { inputFields { type { inputFields { name }}}}}
__schema { types { interfaces { fields { type { interfaces { name } } } } } }
__schema { types { name} }
__type(name : "t") { name }
a1: __schema { types { name} }
a1: __type(name : "t") { name }
a2 : __type(name : "t1") { name }
…
graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.PropertyDataFetcher@6ff0b1cc propertyName=booleanField function=null>, #0] graphql.DataFetcherTest ‑ get Boolean property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1] graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.PropertyDataFetcher@3ba3d4b6 propertyName=booleanFieldWithGet function=null>, #0] graphql.DataFetcherTest ‑ get Boolean property value with get [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1] graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.PropertyDataFetcher@642857e0 propertyName=property function=null>, #0] graphql.DataFetcherTest ‑ get property value [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1] graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.PropertyDataFetcher@6088451e propertyName=publicField function=null>, #0] graphql.DataFetcherTest ‑ get public field value as property [fetcher: <graphql.schema.SingletonPropertyDataFetcher@2262d6d5>, #1] graphql.ScalarsBooleanTest ‑ parseValue throws exception for invalid input <java.lang.Object@551b0266> graphql.ScalarsBooleanTest ‑ serialize throws exception for invalid input <java.lang.Object@255d8982> … ♻️ This comment has been updated with latest results. |
Sorry, something went wrong.
…-config # Conflicts: # src/main/java/graphql/GraphQLUnusualConfiguration.java # src/main/java/graphql/execution/Execution.java # src/test/groovy/graphql/config/GraphQLUnusualConfigurationTest.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This depends on #3945
But this removes the GraphQL aspect of ResponseMapFactory and makes it per context