gh-156106: Add tests for setting and deleting attributes defined in C by serhiy-storchaka · Pull Request #156107 · python/cpython · GitHub

Tests for the attributes defined with PyMemberDef and PyGetSetDef which were not covered: setting a value of an accepted type, of a wrong type or an invalid value, and deleting the attribute.

They are added to the existing tests of the corresponding attributes where such tests exist.

Covered: the plain object members of exceptions, function.__code__, __doc__ and __kwdefaults__, frame.f_trace, f_trace_lines and f_trace_opcodes, the attributes of _ssl._SSLContext and _ssl._SSLSocket, sqlite3 isolation_level, arraysize and autocommit, ctypes raw, contents, argtypes, restype and errcheck, the C Pickler and Unpickler attributes, _io _blksize, _finalizing and _CHUNK_SIZE, the private attributes of decimal.Context, defaultdict.default_factory, Future._cancel_message and the members of select.kevent.

Issue: Add tests for setting and deleting attributes defined in C #156106

…d in C Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered.

… crash

…n-tests

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdca5021d5b6c2cba8121b639bae1642dfe51ff3 3.13

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdca5021d5b6c2cba8121b639bae1642dfe51ff3 3.15

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdca5021d5b6c2cba8121b639bae1642dfe51ff3 3.14

GH-156184 is a backport of this pull request to the 3.14 branch.

…ed in C (GH-156107) (ПР-156184) Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered. (cherry picked from commit cdca502)

GH-156191 is a backport of this pull request to the 3.13 branch.

…ed in C (GH-156107) (GH-156191) Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered. (cherry picked from commit cdca502)

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker cdca5021d5b6c2cba8121b639bae1642dfe51ff3 3.15

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker cdca5021d5b6c2cba8121b639bae1642dfe51ff3 3.15

GH-159086 is a backport of this pull request to the 3.15 branch.

…ed in C (GH-156107) (GH-159086) Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered. (cherry picked from commit cdca502)

pythongh-156106 : Add tests for setting and deleting attributes define…

9087c9d

…d in C Test setting a value of an accepted type, of a wrong type and an invalid value, and deleting the attribute, for the attributes defined with PyMemberDef and PyGetSetDef which were not covered.

serhiy-storchaka requested review from 1st1, asvetlov, erlend-aasland, gpshead, iritkatriel, kumaraditya303, picnixz and willingc as code owners August 20, 2026 11:52

bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Aug 20, 2026

bedevere-app Bot mentioned this pull request Aug 20, 2026

Add tests for setting and deleting attributes defined in C #156106

Open

serhiy-storchaka added the skip news label Aug 20, 2026

serhiy-storchaka added 4 commits August 20, 2026 15:21

Test values which do not fit in C integer types

a0a147e

Restore _finalizing to not emit a ResourceWarning when closing the file

990c249

Move the test for deleting Pointer.contents to the PR which fixes the…

116badf

… crash

Merge remote-tracking branch 'upstream/main' into c-attribute-mutatio…

5a9ff1d

…n-tests

serhiy-storchaka merged commit cdca502 into python:main Aug 21, 2026
86 of 89 checks passed

bedevere-app Bot removed the awaiting core review label Aug 21, 2026

serhiy-storchaka deleted the c-attribute-mutation-tests branch August 21, 2026 13:58

serhiy-storchaka added needs backport to 3.13 only security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Aug 21, 2026

miss-islington-app Bot assigned serhiy-storchaka Aug 21, 2026

serhiy-storchaka mentioned this pull request Aug 21, 2026

[3.14] gh-156106: Add tests for setting and deleting attributes defined in C (GH-156107) #156184

Merged

bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Aug 21, 2026

serhiy-storchaka mentioned this pull request Aug 21, 2026

[3.13] gh-156106: Add tests for setting and deleting attributes defined in C (GH-156107) #156191

Merged

bedevere-app Bot removed the needs backport to 3.13 only security fixes label Aug 21, 2026

serhiy-storchaka added needs backport to 3.15 bugs and security fixes and removed needs backport to 3.15 bugs and security fixes labels Aug 31, 2026

serhiy-storchaka added needs backport to 3.15 bugs and security fixes and removed needs backport to 3.15 bugs and security fixes labels Oct 9, 2026

bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 9, 2026

gh-156106: Add tests for setting and deleting attributes defined in C by serhiy-storchaka · Pull Request #156107 · python/cpython · GitHub

Repository navigation

gh-156106: Add tests for setting and deleting attributes defined in C - #156107

gh-156106: Add tests for setting and deleting attributes defined in C#156107serhiy-storchaka merged 5 commits intopython:mainpython/cpython:mainfrom serhiy-storchaka:c-attribute-mutation-testsserhiy-storchaka/cpython:c-attribute-mutation-testsCopy head branch name to clipboard

Conversation

serhiy-storchaka commented Aug 20, 2026 • edited by bedevere-app Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 21, 2026

Uh oh!

bedevere-app Bot commented Aug 21, 2026

Uh oh!

bedevere-app Bot commented Aug 21, 2026

Uh oh!

miss-islington-app Bot commented Aug 31, 2026

Uh oh!

miss-islington-app Bot commented Aug 31, 2026

Uh oh!

miss-islington-app Bot commented Oct 9, 2026

Uh oh!

miss-islington-app Bot commented Oct 9, 2026

Uh oh!

bedevere-app Bot commented Oct 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gh-156106: Add tests for setting and deleting attributes defined in C#156107
serhiy-storchaka merged 5 commits into
python:mainfrom
serhiy-storchaka:c-attribute-mutation-tests

serhiy-storchaka commented Aug 20, 2026 •
edited by bedevere-app Bot
Loading