FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

gh-131999: Add support for tvOS, visionOS and watchOS. by freakboy3742 · Pull Request #159944 · python/cpython · GitHub

  1. python
  2. cpython

Repository navigation

gh-131999: Add support for tvOS, visionOS and watchOS. - #159944

Open
freakboy3742 wants to merge 5 commits into
python:mainfrom
freakboy3742:tvos-watchos-visionos
ConversationCommits (5)ChecksFiles changed
Open

gh-131999: Add support for tvOS, visionOS and watchOS.#159944
freakboy3742 wants to merge 5 commits into
python:mainfrom
freakboy3742:tvos-watchos-visionos

Conversation

freakboy3742 commented Oct 20, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Adds support for Apple's tvOS, visionOS and watchOS platforms. I've been maintaining these patches independently for a while; I figured I'd try to contribute them upstream.

The support is essentially identical to iOS support, but with different platform identifiers:

  • tvOS -> appletvos and appletvsimulator
  • visionOS -> xros and xrsimulator
  • watchOS -> watchos and watchsimulator

watchOS devices use an arm64_32 architecture that has 32 bit pointers, but 64 bit registers. tvOS and watchOS support both x86_64 and arm64 simulators; visionOS only supports arm64 simulators.

The bulk of the patch (by volume) is the testbed projects and framework skeletons for each new platform.

Usage of the Platform scripts is the same as for iOS; e.g.:

  • python3 Platforms/Apple build tvOS all - build all architectures for tvOS
  • python3 Platforms/Apple test watchOS arm64-apple-watchos-simulator - test for a watchOS simulator
  • python3 Platforms/Apple ci visionOS --fast-ci - Run a fast CI pass (building and running tests) for visionOS.

bedevere-app Bot added the type-feature A feature request or enhancement label Oct 20, 2026
bedevere-app Bot mentioned this pull request Oct 20, 2026
Open

corona10 commented Oct 20, 2026

Copy link
Copy Markdown
Member

cc @DinoV It touches the mimalloc codebase also.

corona10 reviewed Oct 20, 2026
View reviewed changes
Comment thread Include/internal/mimalloc/mimalloc/prim.h
// but system registers are 64 bits.
uint64_t tp; MI_UNUSED(ofs);
#if defined(__APPLE__) // M1, issue #343
__asm__ volatile ("mrs %0, tpidrro_el0\nbic %0, %0, #7" : "=r" (tcb));

corona10 Oct 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Could you add comment when you adding downstream code here

Something like:
// CPython: blahblahblach

corona10 Oct 20, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

We need this when we upgrade mimalloc to the latest version

DinoV Oct 21, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also any chance you could try and upstream this to mimalloc? It seems like it's moved around a little but I think it's here now: https://github.com/microsoft/mimalloc/blob/dev3/include/mimalloc/prim/prim-tls.h#L103C15-L103C19

If we can get it upstreamed into the v3 branch then when we upgrade it'll just be there.

freakboy3742 Oct 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I've added a comment; and I've submitted microsoft/mimalloc#1444 to upstream the equivalent change in mimalloc v3.

corona10 commented Oct 22, 2026

Copy link
Copy Markdown
Member

Could you rebase your PR based on this aff7a2e ?

brettcannon removed their request for review October 22, 2026 17:45

freakboy3742 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

Could you rebase your PR based on this aff7a2e ?

@corona10 Done.

@ned-deily I've also corrected the test failures in test_platform - the failures were a last minute "minor change that won't impact anything..." fix 🤦

corona10 approved these changes Oct 22, 2026
View reviewed changes

corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

freakboy3742 commented Oct 22, 2026

Copy link
Copy Markdown
Contributor Author

@ned-deily One more update as discussed: I've been able to get make testios to work for every "Apple Mobile" platform (which, as a side benefit, also makes the --platform arguments to the testbed case insensitive).

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

DinoV DinoV left review comments
gpshead gpshead approved these changes
corona10 corona10 approved these changes
ned-deily ned-deily approved these changes
FFY00 Awaiting requested review from FFY00 FFY00 is a code owner
warsaw Awaiting requested review from warsaw warsaw is a code owner
pganssle Awaiting requested review from pganssle pganssle is a code owner
StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland is a code owner
1st1 Awaiting requested review from 1st1 1st1 is a code owner
asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner
willingc Awaiting requested review from willingc willingc is a code owner
ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
ZeroIntensity Awaiting requested review from ZeroIntensity ZeroIntensity is a code owner
ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
emmatyping Awaiting requested review from emmatyping emmatyping is a code owner
itamaro Awaiting requested review from itamaro itamaro is a code owner

Assignees

No one assigned

Labels

awaiting merge type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL