Remove add-imaging-libs option from setup.py - #9378
Merged
radarhere merged 1 commit intoJan 3, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
hugovk
approved these changes
Jan 3, 2026
hugovk
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Tip: Co-authored-by can be used to give credit to the original author:
Or even cherry pick if it's a clean commit.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I attempted to cherry-pick, but it wasn't working for me. I do tend to forget about 'Co-authored-by', but thankfully, I was able to do that with 'Squash and merge'. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8389 suggests removing add-imaging-libs from setup.py, as it is undocumented.
It was added in #3399 to allow use when building in AppVeyor. It is no longer used there.
It was also not included when #7171 made sure that other setup options would work with pip >= 23.3 (released October 16, 2023), so it no longer works with recent versions of pip.