FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update protobuf dependencies to v3.22.3 by renovate-bot · Pull Request #1369 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.

deps: update protobuf dependencies to v3.22.3 - #1369

Closed
renovate-bot wants to merge 4 commits into
googleapis:mainfrom
renovate-bot:renovate/protobuf-dependencies
Closed

deps: update protobuf dependencies to v3.22.3#1369
renovate-bot wants to merge 4 commits into
googleapis:mainfrom
renovate-bot:renovate/protobuf-dependencies

Conversation

renovate-bot commented Feb 16, 2023
edited by suztomo
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
com.google.protobuf:protobuf-java (source) 3.21.10 -> 3.22.2
com.google.protobuf:protobuf-bom (source) 3.21.12 -> 3.22.2

⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.


Release Notes

protocolbuffers/protobuf

v3.22.2

Compare Source

v3.22.1

Compare Source

v3.22.0

Compare Source

v3.21.12

Compare Source

v3.21.11

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

renovate-bot requested a review from a team February 16, 2023 20:36
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2023
product-auto-label Bot added the size: xs Pull request size is extra small. label Feb 16, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2023
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2023
blakeli0 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 22, 2023

Copy link
Copy Markdown
Contributor

As discussed with @suztomo, do not merge this until googleapis updates the protobuf compiler version to 3.22.

diegomarquezp left a comment
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

until googleapis updates the protobuf compiler version to 3.22.

trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 27, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 27, 2023
kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 27, 2023

suztomo commented Mar 8, 2023

Copy link
Copy Markdown
Member

Waiting for https://github.com/googleapis/googleapis/blob/master/WORKSPACE#L83 to have Protobuf 3.22.0 or higher.

renovate-bot force-pushed the renovate/protobuf-dependencies branch from b24e0d0 to 402ed10 Compare March 8, 2023 21:16
renovate-bot changed the title deps: update dependency com.google.protobuf:protobuf-bom to v3.22.0 deps: update protobuf dependencies to v3.22.1 Mar 8, 2023
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 8, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 8, 2023
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 8, 2023

suztomo commented Mar 8, 2023
edited
Loading

Copy link
Copy Markdown
Member

@blakeli0 @meltsufin Now the two files (pom.xml and dependencies.properties) are managed by one pull request. Thank you for the pointer today.

But "ci-maven / build" started failing.

/home/runner/.cache/bazel/_bazel_runner/1f815583ebc8da6875b9074f31ba9a5d/external/bazel_tools/tools/build_defs/repo/http.bzl:353:31: in <toplevel>
(21:19:47) ERROR: /home/runner/work/gapic-generator-java/gapic-generator-java/BUILD.bazel:5:12: //:protoc-gen-java_gapic depends on @maven//:com_google_api_gapic_generator_java in repository @maven which failed to fetch. no such package '@maven//': Error while fetching artifact with coursier: OpenJDK 64-Bit Server VM warning: Options -Xverify:none and -noverify were deprecated in JDK 13 and will likely be removed in a future release.
Resolution error: Error downloading $com.google.protobuf:protobuf-java:
  not found: /home/runner/.m2/repository/$com/google/protobuf/protobuf-java/protobuf-java-.pom
  not found: https://repo.maven.apache.org/maven2/$com/google/protobuf/protobuf-java//protobuf-java-.pom

The strange "$" mark seems related to this issue protocolbuffers/protobuf#12170

renovate-bot changed the title deps: update protobuf dependencies to v3.22.1 deps: update protobuf dependencies to v3.22.2 Mar 10, 2023
renovate-bot force-pushed the renovate/protobuf-dependencies branch from 402ed10 to 4a3f641 Compare March 10, 2023 19:24
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Mar 10, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 10, 2023
kokoro-team removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Mar 10, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 13, 2023
kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 13, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Comment thread .bazelrc
Comment on lines +6 to +7
build --cxxopt=-std=c++14
build --host_cxxopt=-std=c++14

suztomo Apr 13, 2023
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

From protocolbuffers/protobuf#12393 to resolve "C++ versions less than C++14 are not supported."

suztomo changed the title deps: update protobuf dependencies to v3.22.2 deps: update protobuf dependencies to v3.22.3 Apr 13, 2023

Copy link
Copy Markdown
Contributor

As of the 4/25 release cycle, the protobuf version in googleapis is 3.21.12: https://github.com/googleapis/googleapis/blob/ab4ba823439f786b2091984fed6408a950aaef9e/WORKSPACE#L83

Keeping this as Do not merge.

alicejli commented May 8, 2023

Copy link
Copy Markdown
Contributor

As of the 5/8 release cycle, the protobuf version in googleapis is 3.21.12: https://github.com/googleapis/googleapis/blame/master/WORKSPACE#L162

Keeping this as Do not merge.

alicejli added the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2023
alicejli self-requested a review May 10, 2023 17:00

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 10, 2023
alicejli added the automerge Merge the pull request once unit tests and other checks pass. label May 11, 2023

Copy link
Copy Markdown
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

gcf-merge-on-green Bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 12, 2023
trusted-contributions-gcf Bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 23, 2023
gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 23, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Copy link
Copy Markdown

[java_showcase_integration_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

Copy link
Copy Markdown

[java_showcase_unit_tests] Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

suztomo commented May 23, 2023

Copy link
Copy Markdown
Member

@mpeddada1 Can you bump the version to 3.23.1?

Copy link
Copy Markdown
Contributor

PR to bump version to 3.23.1 created at #1698

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants


Back | FazBrowse Home | New Git URL