FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 by mpeddada1 · Pull Request #1698 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 - #1698

Merged
mpeddada1 merged 4 commits into
mainfrom
protobuf23.1
May 23, 2023
ConversationCommits (4)ChecksFiles changed
Merged

deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1#1698
mpeddada1 merged 4 commits into
mainfrom
protobuf23.1

Conversation

mpeddada1 commented May 23, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

TODO: Close #1369 after this PR is merged.

mpeddada1 requested a review from a team May 23, 2023 14:28
product-auto-label Bot added the size: xs Pull request size is extra small. label May 23, 2023

suztomo commented May 23, 2023

Copy link
Copy Markdown
Member

You may have to update the C++ option. https://github.com/googleapis/sdk-platform-java/pull/1369/files#r1164950006

mpeddada1 mentioned this pull request May 23, 2023
Closed
1 task

suztomo commented May 23, 2023

Copy link
Copy Markdown
Member

ci / showcase is failing.

  bazel-bin/showcase/verify_proto
(14:45:41) INFO: Elapsed time: 341.420s, Critical Path: 31.43s
(14:45:41) INFO: 625 processes: 219 internal, 388 linux-sandbox, 18 worker.
(14:45:41) INFO: Build completed successfully, 625 total actions
(14:45:41) INFO: Running command line: bazel-bin/showcase/verify_proto proto
diff -ru /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java /home/runner/.cache/bazel/_bazel_runner/cf5fb8c2c66b8a944ea6af7c9b248db5/execroot/gapic_generator_java/bazel-out/k8-fastbuild/bin/showcase/verify_proto.runfiles/gapic_generator_java/proto_unpacked/proto-google-cloud-showcase-v1beta1-java/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java
--- /home/runner/work/sdk-platform-java/sdk-platform-java/showcase/proto-gapic-showcase-v1beta1/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java	2023-05-23 14:38:00.460649223 +0000
+++ /home/runner/.cache/bazel/_bazel_runner/cf5fb8c2c66b8a944ea6af7c9b248db5/execroot/gapic_generator_java/bazel-out/k8-fastbuild/bin/showcase/verify_proto.runfiles/gapic_generator_java/proto_unpacked/proto-google-cloud-showcase-v1beta1-java/src/main/java/com/google/showcase/v1beta1/AttemptSequenceRequest.java	1980-01-01 00:00:00.000000000 +0000
@@ -26,11 +26,6 @@
     return new AttemptSequenceRequest();
   }
 
-  @java.lang.Override
-  public final com.google.protobuf.UnknownFieldSet
-  getUnknownFields() {
-    return this.unknownFields;
-  }
   public static final com.google.protobuf.Descriptors.Descriptor
       getDescriptor() {
     return com.google.showcase.v1beta1.SequenceOuterClass.internal_static_google_showcase_v1beta1_AttemptSequenceRequest_descriptor;
@@ -191,11 +186,13 @@
     return com.google.protobuf.GeneratedMessageV3
         .parseWithIOException(PARSER, input, extensionRegistry);
   }
+
   public static com.google.showcase.v1beta1.AttemptSequenceRequest parseDelimitedFrom(java.io.InputStream input)
       throws java.io.IOException {
     return com.google.protobuf.GeneratedMessageV3
         .parseDelimitedWithIOException(PARSER, input);
   }

=> https://github.com/googleapis/sdk-platform-java/tree/main/showcase#update-the-golden-showcase-files

@mpeddada1 Can you update the golden file?

product-auto-label Bot added size: xl Pull request size is extra large. and removed size: xs Pull request size is extra small. labels May 23, 2023
mpeddada1 requested review from burkedavison and suztomo May 23, 2023 15:19
burkedavison reviewed May 23, 2023
View reviewed changes
Comment thread gax-java/dependencies.properties Outdated
version.com_google_protobuf=3.21.12
version.com_google_protobuf=3.23.1
version.google_java_format=1.15.0
version.io_grpc=1.54.0

burkedavison May 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This version should be updated.

mpeddada1 May 23, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thank you! Done.

mpeddada1 changed the title deps: update protobuf dependencies to v3.23.1 deps: update protobuf dependencies to v3.23.1 and gprc to 1.55.1 May 23, 2023
mpeddada1 requested a review from burkedavison May 23, 2023 15:38

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[gapic-generator-java-root] SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

0.0% Coverage
0.3% Duplication

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[java_showcase_integration_tests] SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

0.0% Coverage
0.3% Duplication

sonarqubecloud Bot commented May 23, 2023

Copy link
Copy Markdown

[java_showcase_unit_tests] SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
12 Code Smells

0.0% Coverage
0.3% Duplication

suztomo commented May 23, 2023

Copy link
Copy Markdown
Member

Sonar is complaining https://github.com/googleapis/sdk-platform-java/pull/1698/checks?check_run_id=13697463444

0.0% Coverage on New Code (is less than 80%)

But we're not adding new code. It's fine.

mpeddada1 mentioned this pull request May 23, 2023
Merged
1 task
mpeddada1 merged commit 1f56175 into main May 23, 2023
mpeddada1 deleted the protobuf23.1 branch May 23, 2023 17:39
release-please Bot mentioned this pull request May 23, 2023
Merged
mpeddada1 mentioned this pull request May 25, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
suztomo suztomo approved these changes
burkedavison burkedavison approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: xl Pull request size is extra large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL