FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix install paths by christophfroehlich · Pull Request #348 · PickNikRobotics/generate_parameter_library · GitHub

Fix install paths - #348

Draft
christophfroehlich wants to merge 4 commits into
mainfrom
install-path
Draft

christophfroehlich wants to merge 4 commits into
mainfrom
install-path

Conversation

Copy link
Copy Markdown
Collaborator

This was completely coded by GPT-5.3-Codex and needs proper review and testing.

Summary

Fix Python generated-parameter module installation/import behavior across all colcon layouts (standard, isolated, and merge-install), resolving intermittent prerelease import failures.

Problem

Tests could fail with:

  • ModuleNotFoundError: No module named 'generate_parameter_module_example.admittance_parameters'
  • ModuleNotFoundError: No module named 'generate_parameter_module_example.custom_validation'

Root causes were path/layout mismatches in generation output handling and empty package __init__.py files in install space.

Changes

Validation

All scenarios pass for generate_parameter_module_example:

  • Standard layout: 48 passed, 0 failed
  • Isolated layout (--build-base/--install-base): 48 passed, 0 failed
  • Merge-install layout (--merge-install): 48 passed, 0 failed

Generated module is now written to the correct install location in each layout.

christophfroehlich added the check-prerelease Runs the pre-release workflow without downstream dependencies label Apr 17, 2026

saikishor left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

As far as I understood, LGTM

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

check-prerelease Runs the pre-release workflow without downstream dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

python setup_helper ignores --install-base flag ModuleNotFoundError python unit test Store codegen result for python code in build folder

2 participants


Back | FazBrowse Home | New Git URL