This repository was archived by the owner on Mar 6, 2026. It is now read-only.
fix: remove py.typed since package fails mypy check - #988
Merged
tswast merged 1 commit intoSep 27, 2021
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit 96e6bee.
Copy link
Copy Markdown
Contributor
Author
|
Will check the library with mypy before reverting. |
Sorry, something went wrong.
dandhlee
approved these changes
Sep 27, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Sep 27, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [2.27.1](https://www.github.com/googleapis/python-bigquery/compare/v2.27.0...v2.27.1) (2021-09-27) ### Bug Fixes * remove py.typed since package fails mypy check ([#988](https://www.github.com/googleapis/python-bigquery/issues/988)) ([39030f2](https://www.github.com/googleapis/python-bigquery/commit/39030f26ce081cfacd456b84694c68e3f04ed48d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Copy link
Copy Markdown
Contributor
|
Do we know what exactly caused that error? Is it an issue with some of our annotations, or does mypy behave differently from pytype? It would be good to fix this while still retaining py.typed, although removing it as a short term fix to unblock maintainers of other is fine. |
Sorry, something went wrong.
4 tasks
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
This reverts commit 96e6bee.
abdelmegahedgoogle
pushed a commit
to abdelmegahedgoogle/python-bigquery
that referenced
this pull request
Apr 17, 2023
🤖 I have created a release \*beep\* \*boop\* --- ### [2.27.1](https://www.github.com/googleapis/python-bigquery/compare/v2.27.0...v2.27.1) (2021-09-27) ### Bug Fixes * remove py.typed since package fails mypy check ([googleapis#988](https://www.github.com/googleapis/python-bigquery/issues/988)) ([39030f2](https://www.github.com/googleapis/python-bigquery/commit/39030f26ce081cfacd456b84694c68e3f04ed48d)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #976
Context: https://issues.apache.org/jira/browse/BEAM-12975