FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fix: permanently broken date & time tests by tina80lvl · Pull Request #524 · googleapis/python-spanner-django · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.

fix: permanently broken date & time tests - #524

Merged
IlyaFaer merged 22 commits into
googleapis:masterfrom
MaxxleLLC:fix-472
Oct 2, 2020
Merged

IlyaFaer merged 22 commits into
googleapis:masterfrom
MaxxleLLC:fix-472

Conversation

Copy link
Copy Markdown
Contributor

Fixes: #472

google-cla Bot commented Sep 30, 2020

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

google-cla Bot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 30, 2020

Copy link
Copy Markdown
Contributor Author

@googlebot I signed it!

google-cla Bot commented Sep 30, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown

@googlebot I consent.

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 30, 2020
IlyaFaer added api: spanner Issues related to the googleapis/python-spanner-django API. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Sep 30, 2020
IlyaFaer requested review from c24t and mf2199 September 30, 2020 10:20
IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 30, 2020

mf2199 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Approving for now, but this PR may later be superseded by #521 that reworks both types and unit tests files.

google-cla Bot commented Sep 30, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

google-cla Bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Sep 30, 2020

google-cla Bot commented Sep 30, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

Copy link
Copy Markdown
Contributor Author

@googlebot I consent.

google-cla Bot commented Sep 30, 2020

Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

mf2199 commented Sep 30, 2020

Copy link
Copy Markdown
Contributor

@googlebot I consent.

google-cla Bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 30, 2020
IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 1, 2020
IlyaFaer marked this pull request as ready for review October 1, 2020 12:48
IlyaFaer requested a review from a team October 1, 2020 12:48
IlyaFaer added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2020
yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 2, 2020
IlyaFaer merged commit 3f5db62 into googleapis:master Oct 2, 2020
IlyaFaer deleted the fix-472 branch October 2, 2020 09:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Couple of tests are permanently broken while running locally

6 participants


Back | FazBrowse Home | New Git URL