Remove deprecated rubyhash constructors - #9494
Draft
headius wants to merge 3 commits into
Draft
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This constructor was restored by deprecation patches from 10.0 in jruby#9474 but the merge of that to 10.1 left it as a normal non-delegated constructor. This patch makes the following changes: * Make this constructor delegate, like the other deprecated RubyHash constructors. * Remove the protected constructor from RubyHashLinkedBuckets, so that it lives only in RubyHash and we can be sure all callers need delegation. The constructor should move back into RubyHashLinkedBuckets as a protected internal constructor once we can safely remove the constructors from RubyHash (10.2 or later).
These constructors have been deprecated since 10.0.3.0 or 10.0.6.0 at the latest and should not be used by third-party code anymore. All RubyHash construction should go through official factory methods that will return an appropriate implementation.
headius
marked this pull request as draft
June 13, 2026 15:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This does a final removal of all public RubyHash constructors, as discussed in #9456. This may or may not end up merging as-is, but is a reminded for 10.2 to revisit whether these constructors can finally be removed.