Disable OpenMP for macOS x86_64 CI builds (no libomp bottle) - #1782
Merged
phkahler merged 1 commit intoOct 3, 2026
Merged
phkahler merged 1 commit into
phkahler merged 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copilot
AI
changed the title
[WIP] Fix macOS CI to handle missing x86_64 libomp bottle
Disable OpenMP for macOS x86_64 CI builds (no libomp bottle)
Oct 2, 2026
Copy link
Copy Markdown
Member
|
@copilot please remove the first empty commit. Also remove copilot attribution. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
I can't do this one. I can't force-push or rewrite history here; my only way to push is report_progress, which adds commits. In this clone "Initial plan" (e31ef5b) is also the shallow-clone root, so I can't drop it locally either. You can squash the two commits, drop the "Initial plan" commit, and edit the author and Co-authored-by lines when you merge, or with a local git rebase -i and force-push. The net change is just the two script edits in a3c3582. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I did it. |
Sorry, something went wrong.
ruevs
force-pushed
the
copilot/fix-macos-ci-libomp-bottle
branch
from
a3c3582 to
4ac9c9b
Compare
October 3, 2026 08:03
ruevs
marked this pull request as ready for review
October 3, 2026 08:04
ruevs
force-pushed
the
copilot/fix-macos-ci-libomp-bottle
branch
from
4ac9c9b to
6bd3af9
Compare
October 3, 2026 08:06
Homebrew's libomp 23.1.1 no longer ships a macOS x86_64 bottle, so `arch -x86_64 brew fetch --bottle-tag=sonoma libomp` returns the formula and the macOS CI job fails. This is not a wrong-tag problem like the earlier bottle failures. This drops OpenMP from the x86_64 macOS slice only. - `install-macos.sh` (CI mode) - Fetch and extract only the arm64 libomp bottle. - Remove the x86_64 fetch, lookup and extraction. - `build-macos.sh` - `ENABLE_OPENMP` is now a variable that defaults to `ON`. - The `x86_64` branch sets it to `OFF` and no longer sets a libomp `CMAKE_PREFIX_PATH`. - Behaviour: x86_64 macOS builds are single-threaded for the geometric operations that OpenMP parallelizes. arm64 builds keep OpenMP. - Default case: builds with no architecture argument, which are the non-CI path using `brew install libomp`, are unchanged and still have OpenMP on.
ruevs
force-pushed
the
copilot/fix-macos-ci-libomp-bottle
branch
from
6bd3af9 to
b6326fa
Compare
October 3, 2026 08:07
dodox1
added a commit
to dodox1/neosolve
that referenced
this pull request
Oct 3, 2026
cd1b07b stopped fetching the Intel libomp bottle, because Homebrew no longer publishes one, but the build script still pointed CMAKE_PREFIX_PATH at the directory that fetch used to create and still asked for ENABLE_OPENMP=ON. CI never noticed, it has built arm64 only since ff6df07, so this only bites someone running the script by hand. Turn ENABLE_OPENMP into a variable and set it OFF for x86_64, which is what upstream settled on in solvespace#1782, closing the issue we filed as solvespace#1777. Ours keeps the OpenCASCADE prefix there, which upstream has no need of.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Homebrew's libomp 23.1.1 no longer ships a macOS x86_64 bottle, so arch -x86_64 brew fetch --bottle-tag=sonoma libomp returns the formula and the macOS CI job fails. This is not a wrong-tag problem like the earlier bottle failures. This PR drops OpenMP from the x86_64 macOS slice only.