FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Set CMP0144 before finding PCL by Daniiiil1 · Pull Request #543 · ANYbotics/grid_map · GitHub

Set CMP0144 before finding PCL - #543

Open
Daniiiil1 wants to merge 1 commit into
ANYbotics:rollingfrom
Daniiiil1:codex/set-cmp0144-before-pcl
Open

Set CMP0144 before finding PCL#543
Daniiiil1 wants to merge 1 commit into
ANYbotics:rollingfrom
Daniiiil1:codex/set-cmp0144-before-pcl

Conversation

Copy link
Copy Markdown

Summary

  • select CMake policy CMP0144 before loading PCL in grid_map_pcl
  • apply the same guarded policy selection in grid_map_sdf
  • retain compatibility with CMake versions that predate CMP0144

This prevents CMake 3.27+ developer warnings when PCL configures dependencies through legacy upper-case variables such as EIGEN_ROOT and FLANN_ROOT.

Validation

  • git diff --check
  • verified the guarded policy selection precedes each find_package(PCL ...) call
  • parsed both edited CMake files with CMake 4.4.2 available locally; a full ROS 2/PCL workspace build is left to project CI because that toolchain is not installed locally

Fixes #441

Signed-off-by: Daniil Mordanov mordanovdania@gmail.com

Signed-off-by: Daniil Mordanov <mordanovdania@gmail.com>

mergify Bot commented Aug 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant


Back | FazBrowse Home | New Git URL