Color frame is rgb - #9
Open
efernandez wants to merge 3 commits into
Open
efernandez wants to merge 3 commits into
efernandez wants to merge 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Defaults to false.
It's RGB8, not MONO8. It's also possible to do a shallow copy instead of a deep copy, so the conversion is faster.
efernandez
force-pushed
the
color_frame_is_rgb
branch
from
ddcddc9 to
c1e0d63
Compare
March 5, 2019 21:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #8, this fixes the visible/color frame, which is RGB8 not MONO8.
Before this PR (left):
After this PR:
Exposure is fix and illumination is relatively low, so the image is a little dark and noisy.
It's a shame this ROS wrapper doesn't allow to change the exposure. 😢
I think the IR images could also use a shallow copy as I do here for the visible/color image.
That would also be possible for the depth image if it were uint16_t or float, but already in meters instead of millimeters.