FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Clean up the code and fix the sample tests by nnegrey · Pull Request #1463 · GoogleCloudPlatform/java-docs-samples · GitHub

/ java-docs-samples Public

Clean up the code and fix the sample tests - #1463

Merged
nnegrey merged 1 commit into
masterfrom
automl-cleanup
Jun 12, 2019
ConversationCommits (1)ChecksFiles changed
Merged

Clean up the code and fix the sample tests#1463
nnegrey merged 1 commit into
masterfrom
automl-cleanup

Conversation

nnegrey commented Jun 12, 2019

Copy link
Copy Markdown
Contributor

nnegrey requested a review from a team June 12, 2019 17:30
googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2019
lesv reviewed Jun 12, 2019
View reviewed changes
Comment thread vision/automl/src/main/java/com/google/cloud/vision/samples/automl/PredictionApi.java

String projectId = System.getenv("PROJECT_ID");
String projectId = System.getenv("GOOGLE_CLOUD_PROJECT");
String computeRegion = System.getenv("REGION_NAME");

lesv Jun 12, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm fine w/ this, but don't we have a standard of ZONE & REGION, if not, should we?

nnegrey Jun 12, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Sorry, clarification question: do you mean like the var name should be REGION or like we should provide a suggested default region: us-central1?

lesv approved these changes Jun 12, 2019
View reviewed changes

lesv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM - consider the question about REGION_NAME

nnegrey merged commit 81243cb into master Jun 12, 2019
nnegrey deleted the automl-cleanup branch June 12, 2019 18:17
Shabirmean pushed a commit that referenced this pull request Nov 17, 2022
samples: migrate samples from GoogleCloudPlatform/java-docs-samples /…
2f559d2 
…vision/automl (#261)

* samples: Automl (#1158)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* samples: Automl (#1162)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* Updates based on comments

* Updates after review comments

* Fixed build issue

* samples: Clean up the code and fix the sample tests (#1463)

* samples: Prevent Name collisions on tests (#1466)

* samples: fix misspelling reported by user (#1451)

* samples: Auto-update dependencies. (#1467)

* Auto-update dependencies.

* Rollback

* Auto-update dependencies.

* Fix merge errors

* Rollback

* Fix tests

* Fix test

* samples: Add new sample for deploying a model with a node count (#1601)

* samples: Add missing samples for classification and rename object detection sa… (#1604)

* Add missing samples for classification and rename object detection sample to add clarification

* Update test function names

* samples: automl: fix old beta snippet tests (#1994)

* samples: docs: update tests that are failing or not cleaning up resources

* samples: update shared config (#2443)

* update shared config

* Update to 1.0.13

* lint

* Fix linting

* lint

* fix imports

Co-authored-by: Les Vogel <lesv@users.noreply.github.com>

* samples: bug: fix importData sample in order to bump libraries-bom version (#3011)

Fixes #2943

* samples: automl: remove vision samples no longer on cgc (#2844)

- [ x] `pom.xml` parent set to latest `shared-configuration`
- [ in progress] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
- [see below] Tests pass (`mvn -P lint clean verify`)
- [x ] Please **merge** this PR for me once it is approved.

Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here.

* samples: samples: increased wait time for undeployed model prediction (#3286)

* samples: increased wait time for undeployed model prediction

* fixed the lint issue

Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com>
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com>
Co-authored-by: DPEBot <dpebot@google.com>
Co-authored-by: nnegrey <nnegrey@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Les Vogel <lesv@users.noreply.github.com>
Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Co-authored-by: Anthony <wens.ajw@gmail.com>
Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
Shabirmean pushed a commit that referenced this pull request Nov 18, 2022
samples: migrate samples from GoogleCloudPlatform/java-docs-samples /…
1c58f75 
…vision/automl (#261)

* samples: Automl (#1158)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* samples: Automl (#1162)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* Updates based on comments

* Updates after review comments

* Fixed build issue

* samples: Clean up the code and fix the sample tests (#1463)

* samples: Prevent Name collisions on tests (#1466)

* samples: fix misspelling reported by user (#1451)

* samples: Auto-update dependencies. (#1467)

* Auto-update dependencies.

* Rollback

* Auto-update dependencies.

* Fix merge errors

* Rollback

* Fix tests

* Fix test

* samples: Add new sample for deploying a model with a node count (#1601)

* samples: Add missing samples for classification and rename object detection sa… (#1604)

* Add missing samples for classification and rename object detection sample to add clarification

* Update test function names

* samples: automl: fix old beta snippet tests (#1994)

* samples: docs: update tests that are failing or not cleaning up resources

* samples: update shared config (#2443)

* update shared config

* Update to 1.0.13

* lint

* Fix linting

* lint

* fix imports

Co-authored-by: Les Vogel <lesv@users.noreply.github.com>

* samples: bug: fix importData sample in order to bump libraries-bom version (#3011)

Fixes #2943

* samples: automl: remove vision samples no longer on cgc (#2844)

- [ x] `pom.xml` parent set to latest `shared-configuration`
- [ in progress] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
- [see below] Tests pass (`mvn -P lint clean verify`)
- [x ] Please **merge** this PR for me once it is approved.

Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here.

* samples: samples: increased wait time for undeployed model prediction (#3286)

* samples: increased wait time for undeployed model prediction

* fixed the lint issue

Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com>
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com>
Co-authored-by: DPEBot <dpebot@google.com>
Co-authored-by: nnegrey <nnegrey@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Les Vogel <lesv@users.noreply.github.com>
Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Co-authored-by: Anthony <wens.ajw@gmail.com>
Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
anguillanneuf pushed a commit that referenced this pull request Dec 5, 2022
samples: migrate samples from GoogleCloudPlatform/java-docs-samples /…
9436da0 
…vision/automl (#261)

* samples: Automl (#1158)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* samples: Automl (#1162)

* Test push

* Vision AutoML

* Vision AutoML updates + Translate AutoML

* Translate README fixes

* Fixing Kokoro failure issue

* Language AutoML

* Vision AutoML

* Translate AutoML files added

* Triggering tests

* Triggering tests

* Updates based on comments

* Updates after review comments

* Fixed build issue

* samples: Clean up the code and fix the sample tests (#1463)

* samples: Prevent Name collisions on tests (#1466)

* samples: fix misspelling reported by user (#1451)

* samples: Auto-update dependencies. (#1467)

* Auto-update dependencies.

* Rollback

* Auto-update dependencies.

* Fix merge errors

* Rollback

* Fix tests

* Fix test

* samples: Add new sample for deploying a model with a node count (#1601)

* samples: Add missing samples for classification and rename object detection sa… (#1604)

* Add missing samples for classification and rename object detection sample to add clarification

* Update test function names

* samples: automl: fix old beta snippet tests (#1994)

* samples: docs: update tests that are failing or not cleaning up resources

* samples: update shared config (#2443)

* update shared config

* Update to 1.0.13

* lint

* Fix linting

* lint

* fix imports

Co-authored-by: Les Vogel <lesv@users.noreply.github.com>

* samples: bug: fix importData sample in order to bump libraries-bom version (#3011)

Fixes #2943

* samples: automl: remove vision samples no longer on cgc (#2844)

- [ x] `pom.xml` parent set to latest `shared-configuration`
- [ in progress] Appropriate changes to README are included in PR
- [ ] API's need to be enabled to test (tell us)
- [ ] Environment Variables need to be set (ask us to set them)
- [see below] Tests pass (`mvn -P lint clean verify`)
- [x ] Please **merge** this PR for me once it is approved.

Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here.

* samples: samples: increased wait time for undeployed model prediction (#3286)

* samples: increased wait time for undeployed model prediction

* fixed the lint issue

Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com>
Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com>
Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com>
Co-authored-by: DPEBot <dpebot@google.com>
Co-authored-by: nnegrey <nnegrey@google.com>
Co-authored-by: Averi Kitsch <akitsch@google.com>
Co-authored-by: Les Vogel <lesv@users.noreply.github.com>
Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com>
Co-authored-by: Anthony <wens.ajw@gmail.com>
Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
lesv lesv approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL