automl: remove vision samples no longer on cgc - #2844
Merged
gcf-merge-on-green[bot] merged 5 commits intoJun 11, 2020
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lesv
approved these changes
May 5, 2020
Copy link
Copy Markdown
Contributor
|
Anthony - please join the org at github/ (internal site) |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Java 8------------------------------------------------------------
- testing vision/automl
------------------------------------------------------------
[java] JVM args ignored when same JVM is used.
[ERROR] Boxing/unboxing to parse a primitive com.google.cloud.vision.samples.automl.ModelApi.createModel(String, String, String, String, String) [com.google.cloud.vision.samples.automl.ModelApi, com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 76]Another occurrence at ModelApi.java:[line 79] DM_BOXED_PRIMITIVE_FOR_PARSING
[ERROR] com.google.cloud.vision.samples.automl.ModelApi.argsHelper(String[]) invokes System.exit(...), which shuts down the entire virtual machine [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 126] DM_EXIT
[ERROR] Method com.google.cloud.vision.samples.automl.ModelApi.createModel(String, String, String, String, String) prints the stack trace to the console [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 99] IMC_IMMATURE_CLASS_PRINTSTACKTRACE
[ERROR] Possible information exposure through an error message [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 99] INFORMATION_EXPOSURE_THROUGH_AN_ERROR_MESSAGE
[ERROR] Method com.google.cloud.vision.samples.automl.ModelApi.createModel(String, String, String, String, String) converts String to primitive using excessive boxing [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 76] NAB_NEEDLESS_BOXING_PARSE
[ERROR] Method com.google.cloud.vision.samples.automl.ModelApi.createModel(String, String, String, String, String) converts String to primitive using excessive boxing [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[line 79] NAB_NEEDLESS_BOXING_PARSE
[ERROR] Method com.google.cloud.vision.samples.automl.ModelApi.argsHelper(String[]) defines parameter list with array as last argument, rather than vararg [com.google.cloud.vision.samples.automl.ModelApi] At ModelApi.java:[lines 109-142] UVA_USE_VAR_ARGS
[ERROR] com.google.cloud.vision.samples.automl.PredictionApi.argsHelper(String[]) invokes System.exit(...), which shuts down the entire virtual machine [com.google.cloud.vision.samples.automl.PredictionApi] At PredictionApi.java:[line 121] DM_EXIT
[ERROR] Method com.google.cloud.vision.samples.automl.PredictionApi.predict(String, String, String, String, String) prints the stack trace to the console [com.google.cloud.vision.samples.automl.PredictionApi] At PredictionApi.java:[line 96] IMC_IMMATURE_CLASS_PRINTSTACKTRACE
[ERROR] This API (java/nio/file/Paths.get(Ljava/lang/String;[Ljava/lang/String;)Ljava/nio/file/Path;) reads a file whose location might be specified by user input [com.google.cloud.vision.samples.automl.PredictionApi, com.google.cloud.vision.samples.automl.PredictionApi] At PredictionApi.java:[line 77]At PredictionApi.java:[line 126] PATH_TRAVERSAL_IN
[ERROR] Method com.google.cloud.vision.samples.automl.PredictionApi.argsHelper(String[]) defines parameter list with array as last argument, rather than vararg [com.google.cloud.vision.samples.automl.PredictionApi] At PredictionApi.java:[lines 106-135] UVA_USE_VAR_ARGS
[ERROR] COMPILATION ERROR :
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[56,13] cannot find symbol
symbol: method listModels(java.lang.String,java.lang.String,java.lang.String)
location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[64,13] cannot find symbol
symbol: method getModel(java.lang.String,java.lang.String,java.lang.String)
location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[71,13] cannot find symbol
symbol: method listModelEvaluations(java.lang.String,java.lang.String,java.lang.String,java.lang.String)
location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[79,13] cannot find symbol
symbol: method getModelEvaluation(java.lang.String,java.lang.String,java.lang.String,java.lang.String)
location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project vision-automl: Compilation failure: Compilation failure:
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[56,13] cannot find symbol
[ERROR] symbol: method listModels(java.lang.String,java.lang.String,java.lang.String)
[ERROR] location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[64,13] cannot find symbol
[ERROR] symbol: method getModel(java.lang.String,java.lang.String,java.lang.String)
[ERROR] location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[71,13] cannot find symbol
[ERROR] symbol: method listModelEvaluations(java.lang.String,java.lang.String,java.lang.String,java.lang.String)
[ERROR] location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] /tmpfs/src/github/java-docs-samples/vision/automl/src/test/java/com/google/cloud/vision/samples/automl/ModelApiIT.java:[79,13] cannot find symbol
[ERROR] symbol: method getModelEvaluation(java.lang.String,java.lang.String,java.lang.String,java.lang.String)
[ERROR] location: class com.google.cloud.vision.samples.automl.ModelApi
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
Testing failed: Maven returned a non-zero exit code.
|
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@lesv - Joined org. I also removed the modelapi test entirely (something I pointed out in my initial comment). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@Strykrol Sorry - Not sure how this got overlooked. Should we close this? Or do you want to resolve the conflicts and redo? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@lesv - I merged the latest changes and resolved deletion conflicts. |
Sorry, something went wrong.
lesv
approved these changes
Jun 11, 2020
Shabirmean
pushed a commit
that referenced
this pull request
Nov 17, 2022
…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <lesv@users.noreply.github.com> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com> Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com> Co-authored-by: DPEBot <dpebot@google.com> Co-authored-by: nnegrey <nnegrey@google.com> Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Les Vogel <lesv@users.noreply.github.com> Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com> Co-authored-by: Anthony <wens.ajw@gmail.com> Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
Shabirmean
pushed a commit
that referenced
this pull request
Nov 18, 2022
…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <lesv@users.noreply.github.com> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com> Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com> Co-authored-by: DPEBot <dpebot@google.com> Co-authored-by: nnegrey <nnegrey@google.com> Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Les Vogel <lesv@users.noreply.github.com> Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com> Co-authored-by: Anthony <wens.ajw@gmail.com> Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
anguillanneuf
pushed a commit
that referenced
this pull request
Dec 5, 2022
…vision/automl (#261) * samples: Automl (#1158) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * samples: Automl (#1162) * Test push * Vision AutoML * Vision AutoML updates + Translate AutoML * Translate README fixes * Fixing Kokoro failure issue * Language AutoML * Vision AutoML * Translate AutoML files added * Triggering tests * Triggering tests * Updates based on comments * Updates after review comments * Fixed build issue * samples: Clean up the code and fix the sample tests (#1463) * samples: Prevent Name collisions on tests (#1466) * samples: fix misspelling reported by user (#1451) * samples: Auto-update dependencies. (#1467) * Auto-update dependencies. * Rollback * Auto-update dependencies. * Fix merge errors * Rollback * Fix tests * Fix test * samples: Add new sample for deploying a model with a node count (#1601) * samples: Add missing samples for classification and rename object detection sa… (#1604) * Add missing samples for classification and rename object detection sample to add clarification * Update test function names * samples: automl: fix old beta snippet tests (#1994) * samples: docs: update tests that are failing or not cleaning up resources * samples: update shared config (#2443) * update shared config * Update to 1.0.13 * lint * Fix linting * lint * fix imports Co-authored-by: Les Vogel <lesv@users.noreply.github.com> * samples: bug: fix importData sample in order to bump libraries-bom version (#3011) Fixes #2943 * samples: automl: remove vision samples no longer on cgc (#2844) - [ x] `pom.xml` parent set to latest `shared-configuration` - [ in progress] Appropriate changes to README are included in PR - [ ] API's need to be enabled to test (tell us) - [ ] Environment Variables need to be set (ask us to set them) - [see below] Tests pass (`mvn -P lint clean verify`) - [x ] Please **merge** this PR for me once it is approved. Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here. * samples: samples: increased wait time for undeployed model prediction (#3286) * samples: increased wait time for undeployed model prediction * fixed the lint issue Co-authored-by: Nirupa Anantha Kumar <nirupa-kumar@users.noreply.github.com> Co-authored-by: Noah Negrey <nnegrey@users.noreply.github.com> Co-authored-by: Andrew Ferlitsch <aferlitsch@gmail.com> Co-authored-by: DPEBot <dpebot@google.com> Co-authored-by: nnegrey <nnegrey@google.com> Co-authored-by: Averi Kitsch <akitsch@google.com> Co-authored-by: Les Vogel <lesv@users.noreply.github.com> Co-authored-by: Stephanie Wang <stephaniewang526@users.noreply.github.com> Co-authored-by: Anthony <wens.ajw@gmail.com> Co-authored-by: Mike <45373284+munkhuushmgl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to take a look still at modelApi tests (it looks like the entire file is obviated, but could be refactored to test model creation?) Could use a second set of eyes here.