Feignconfiguration and volume feignClient along with desired POJOs - #2
Closed
rajiv-jain-netapp wants to merge 2 commits into
Closed
Feignconfiguration and volume feignClient along with desired POJOs#2rajiv-jain-netapp wants to merge 2 commits into
rajiv-jain-netapp wants to merge 2 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
added volume feign, fiegn configuration which is expected to be common across all the feign clients and modal classes for DTO and POJOs |
Sorry, something went wrong.
suryag1201
reviewed
Oct 13, 2025
Comment thread
...orage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/FeignConfiguration.java
|
|
||
| private String ontapFeignMaxConnection = "80"; | ||
|
|
||
| private String ontapFeignMaxConnectionPerRoute = "20"; |
Copy link
Copy Markdown
There was a problem hiding this comment.
we should keep these in property file
Sorry, something went wrong.
sandeeplocharla
pushed a commit
that referenced
this pull request
Oct 21, 2025
…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues
piyush5netapp
pushed a commit
that referenced
this pull request
Dec 4, 2025
# This is the 1st commit message: NFS Cloudstack volume and export policy utils # This is the commit message #2: Licencse add in files # This is the commit message #3: accessgroup create recode # This is the commit message #4: creatacessgroup for NFS impl # This is the commit message #5: storage pool mounting on host # This is the commit message #6: storage pool mounting on host 1 # This is the commit message #7: vm restart issue # This is the commit message #8: vm restart issue 1 # This is the commit message #9: vm restart issue 2 # This is the commit message #10: vm instance creation test1 # This is the commit message #11: vm instance creation test4
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?