Feignconfiguration and volume feignClient along with desired POJOs with cstack 28 by rajiv-jain-netapp · Pull Request #4 · NetApp/cloudstack · GitHub

Description

This PR...

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

BLOCKER
Critical
Major
Minor
Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Do we need this?

for now yes, we can remove it later if required.

It is better to keep version under properties tag as it is easy to maintain. Same is applicable for other dependencies

done

Please use @Getter/ @Setter annotation or @DaTa annotation to remove these getters/setters

I am trying to keep dependencies less. Hence prefer to write getter and setter manually

There is one caveat with @DaTa , it writes its own equals and hashcode method by comparing all fields of object which we dont want sometimes.

same here, use @DaTa annotation for other classes also

Same as above response

we should keep this DTO outside bcz it can be reusable by other DTOs also

I thought of keeping them inside for now and taking them out case by case. That way, we can keep the count of files lower. The number of files is already shooting up.

responded on the comments, reposting the changes with the new changes as per comments

Need to include both spring-web and spring-boot-starter(v2.7.10), if we intend to use @FeignClient annotation in VolumeFeignClient.java

As mentioned earlier, I don't see any compilation issues with the newly added code. If additional dependencies are required as we proceed, we can incorporate them accordingly. For now, I'd prefer not to include all potential dependencies until the corresponding code is in place.

reverted to the comments

I see in some model we are using JsonProperty and SerializedName which serves same purpose but are from 2 different libraries. What's your thought on using Jackson or gson any one of the above across our models.

There is one caveat with @DaTa , it writes its own equals and hashcode method by comparing all fields of object which we dont want sometimes.

…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues

# This is the 1st commit message: NFS Cloudstack volume and export policy utils # This is the commit message #2: Licencse add in files # This is the commit message #3: accessgroup create recode # This is the commit message #4: creatacessgroup for NFS impl # This is the commit message #5: storage pool mounting on host # This is the commit message #6: storage pool mounting on host 1 # This is the commit message #7: vm restart issue # This is the commit message #8: vm restart issue 1 # This is the commit message #9: vm restart issue 2 # This is the commit message #10: vm instance creation test1 # This is the commit message #11: vm instance creation test4

rajiv-jain-netapp added 4 commits October 13, 2025 16:01

Feignconfiguration and volume feignClient along with desired POJOs

2e0efe8

Feignconfiguration and volume feignClient along with desired POJOs

a96eb9e

CSTACKEX-28: added copyright comment in the logger configuration

0f09c5f

CSTACKEX-28: added newline in the end of the file

2cc4b0c

rajiv-jain-netapp requested review from piyush5netapp, sandeeplocharla and suryag1201 October 13, 2025 11:55

sandeeplocharla reviewed Oct 13, 2025

View reviewed changes

rajiv-jain-netapp requested a review from sandeeplocharla October 13, 2025 13:07

suryag1201 reviewed Oct 13, 2025

View reviewed changes

rajiv-jain-netapp commented Oct 14, 2025

View reviewed changes

CSTACKEX-28 - incorporated review comments

033c23d

sandeeplocharla reviewed Oct 14, 2025

View reviewed changes

rajiv-jain-netapp commented Oct 14, 2025

View reviewed changes

sandeeplocharla approved these changes Oct 14, 2025

View reviewed changes

suryag1201 approved these changes Oct 14, 2025

View reviewed changes

rajiv-jain-netapp merged commit 2822946 into main Oct 14, 2025
16 checks passed

piyush5netapp approved these changes Oct 14, 2025

View reviewed changes

                           <artifactId>cloud-engine-storage-volume</artifactId>
                           <version>${project.version}</version>
                       </dependency>
+                      <dependency>

+                  <properties>
+                      <spring-cloud.version>2021.0.7</spring-cloud.version>
+                      <openfeign.version>11.0</openfeign.version>
+                  </properties>

		@@ -38,14 +53,47 @@
		<artifactId>json</artifactId>
		<version>20230227</version>

+                  private List<AggregateDTO> aggregates;
+                  private SvmDTO svm;
+                  // getters and setters

+                  public static class Job {
+                      private String uuid;
+                      private Links links;

+                      public void setName(String name) { this.name = name; }
+                  }
+                  public static class SvmDTO {

+              @JsonInclude(JsonInclude.Include.NON_NULL)
+              public class Aggregate {
+                  @SerializedName("name")

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28 by rajiv-jain-netapp · Pull Request #4 · NetApp/cloudstack · GitHub

Uh oh!

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28 - #4

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28#4rajiv-jain-netapp merged 5 commits intomainNetApp/cloudstack:mainfrom feature/CSTACKEX-28NetApp/cloudstack:feature/CSTACKEX-28Copy head branch name to clipboard

Conversation

rajiv-jain-netapp commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

suryag1201 Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajiv-jain-netapp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajiv-jain-netapp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28#4
rajiv-jain-netapp merged 5 commits into
mainfrom
feature/CSTACKEX-28

rajiv-jain-netapp commented Oct 13, 2025 •
edited
Loading

suryag1201 Oct 13, 2025 •
edited
Loading