CSTACKEX-30 SAN Feign Client - #8
Conversation
Sorry, something went wrong.
| import java.net.URI; | ||
|
|
||
| @Lazy | ||
| @FeignClient(name = "SANClient", url = "", configuration = FeignConfiguration.class ) |
There was a problem hiding this comment.
Why is the URL field empty?
Sorry, something went wrong.
There was a problem hiding this comment.
this feign client has multiple resources like lun, iGroup, LunMap. All have different different URLs. So, kept empty bcz we can use the method level baseURL like below:
OntapResponse getLunResponse(URI baseURL, @RequestHeader("Authorization") String authHeader);
Sorry, something went wrong.
…ommits. # This is the 1st commit message: CSTACKEX-25: Basic class structure # This is the commit message #2: Add PrimaryStoragePool base code # This is the commit message #3: CSTACKEX-25: Create Volume code basic code added # This is the commit message #4: CSTACKEX-25: additional logic for Primary storage pool creation # This is the commit message #5: CSTACKEX-29 Cluster, SVM and Aggr Feign Client # This is the commit message #6: CSTACKEX-29 Added License Info # This is the commit message #7: CSTACKEX-29 Resolve Review Comments # This is the commit message #8: CSTACKEX-29 Resolve Style check issues � This is the commit message #9: CSTACKEX-29 Resolve Style check issues � This is the commit message #10: CSTACKEX-29 Resolve Precommits Issues # This is the commit message #11: CSTACKEX-29 Resolve Precommits Issues
| public enum OsTypeEnum { | ||
| hyper_v("hyper_v"), | ||
|
|
||
| linux("linux"), |
There was a problem hiding this comment.
How do we map 'kvm' here, to 'linux'? Also, shall we restrict this list to the one's that we would support for first drop?
Sorry, something went wrong.
There was a problem hiding this comment.
should be linux and also reduced the list
Sorry, something went wrong.
| public enum ProtocolEnum { | ||
| iscsi("iscsi"), | ||
|
|
||
| mixed("mixed"); |
There was a problem hiding this comment.
do we need mixed?
Sorry, something went wrong.
There was a problem hiding this comment.
yes, for FC we need
Sorry, something went wrong.
|
|
||
| PROTOCOL_ENDPOINT("protocol_endpoint"), | ||
|
|
||
| VVOL("vvol"); |
There was a problem hiding this comment.
VVOL?
Sorry, something went wrong.
There was a problem hiding this comment.
removed it
Sorry, something went wrong.
|
|
||
| OPENVMS("openvms"), | ||
|
|
||
| SOLARIS("solaris"), |
There was a problem hiding this comment.
here also, shall we restrict this list?
Sorry, something went wrong.
There was a problem hiding this comment.
done!
Sorry, something went wrong.
* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
# This is the 1st commit message: NFS Cloudstack volume and export policy utils # This is the commit message #2: Licencse add in files # This is the commit message #3: accessgroup create recode # This is the commit message #4: creatacessgroup for NFS impl # This is the commit message #5: storage pool mounting on host # This is the commit message #6: storage pool mounting on host 1 # This is the commit message #7: vm restart issue # This is the commit message #8: vm restart issue 1 # This is the commit message #9: vm restart issue 2 # This is the commit message #10: vm instance creation test1 # This is the commit message #11: vm instance creation test4
* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>
Description
SAN Feign Client and Models
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?