| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
There was a problem hiding this comment.
LGTM but I would wait for Noel/Emma second check
Sorry, something went wrong.
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop-2.0.0 #4102 +/- ##
=================================================
+ Coverage 73.81% 73.88% +0.06%
=================================================
Files 172 172
Lines 28095 28095
=================================================
+ Hits 20739 20758 +19
+ Misses 7356 7337 -19
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes
|
Sorry, something went wrong.
* chore: Adding a note about DontDestroyOnLoad usage for Networked scene objects (#4070) Docs correction * ci: Split code coverage into Package Test and Project Test jobs (#4101) * ci: Split code coverage into Package Test and Project Test jobs Convert the existing coverage job to [Code Coverage] Package Test - NGO [ubuntu, trunk] and add [Code Coverage] Project Test - NGO testproject [ubuntu, trunk]. Wire Package Test into PR/nightly triggers and Project Test into the weekly run. * ci: Run both coverage jobs on PR and nightly * ci: Use pinnedTrunk for PR coverage and drop package-test job * chore: Point CMB resources at new monorepo (#4106) * chore: Point CMB resources at new monorepo * fix: NetworkVariable change prior to ownership change using distributed authority topology fails to sync NetworkVariable (#4107) * fix This resolves the issue where in a distributed authority session changing a NetworkVariable prior to changing ownership in the same call-stack would result in the NetworkVariable not being synchronized. * fix - update Removing the additional authority check as it is not needed. Fixing a very edge case scenario that shouldn't happen but in the event it does when finding objects by type within a specific scene, if the scene is invalid then use an empty array for the found objects. * fix: spawn disabled in scene placed and network prefab registration (#4093) * fix - Issue where disabled in-scene placed NetworkObjects could not be spawned after starting a session. - Issue where users are allowed to spawn a NetworkObject with a GlobalObjectIdHash value of 0 (zero). * update NetworkAnimator not pointing to an animator within awake now just logs a warning as opposed to an error. * test Updating tests based on the fixes applied to this branch. A large portion is related to some integration tests trying to spawn NetworkObjects with a GlobalObjectIdHash value of zero(0). * update Style and providing internal write access to the prefabs list. * test Potentially last iteration on fixing/updating integration tests. * test - fix Using the fixed version of NetworkPrefabHandlerSpawnAndSynchronizeTests. Fixing some issues with prefab and handler creation. * style Fixing formatting issues. * style Fixing some standards formatting related issues. * style removing trailing spaces. * style Super weird one... but using ? as opposed to an if null check. * style Removing commented out code that is no longer needed/used. * update Committing suggested changes. Co-authored-by: Emma <emma.mcmillan@unity3d.com> * update Applying changes based on review discussion. * update Making adjustments based on review discussion. * style Removing field that is no longer valid. Moving Awake higher in NetworkObject as it has become wedged in the middle of the code. * update Adding change log entries. * update Inverting logic (oops) * doc Updating NetworkObject documentation and in-scene placed documentation. * Update documentation for the two types of NetworkObjects Clarified the categories of NetworkObjects and their requirements. Added details for dynamically instantiated and in-scene placed NetworkObjects. * style White spaces! * Apply suggestions from code review Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> --------- Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> * docs: Docs-wide link fixes and xref update (#4102) * Docs-wide link fixes and xref update * Typo in API docs * chore: Add NGO_EXCLUDE_HEAVY_TESTS define (#4114) Add NGO_EXCLUDE_HEAVY_TESTS --------- Co-authored-by: Nikos <nikos@unity3d.com> Co-authored-by: Emma <emma.mcmillan@unity3d.com> Co-authored-by: Noel Stephens <noel.stephens@unity3d.com> Co-authored-by: Amy Reeve <amy.reeve@unity3d.com> Co-authored-by: mnachury-unity <120488254+mnachury-unity@users.noreply.github.com>
| Back | FazBrowse Home | New Git URL |
Purpose of this PR
Docs-wide link fixes using Claude, as well as converting all links to API members to xrefs, which is the recommended format and means they'll resolve to the version matching the one the user is already in. And a typo fix for some API docs.
Jira ticket
A bunch of feedback we just got in in the DOCMP project
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Built locally and checked
Up-port
#4103
Backports
N/A NGO 1.0 will be unsupported soon