FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ARROW-16715: [R] Bump default parquet version by nealrichardson · Pull Request #13555 · apache/arrow · GitHub

/ arrow Public

ARROW-16715: [R] Bump default parquet version - #13555

Merged
nealrichardson merged 4 commits into
apache:masterfrom
nealrichardson:r-upgrade-parquet
Jul 11, 2022
ConversationCommits (4)ChecksFiles changed
Merged

ARROW-16715: [R] Bump default parquet version#13555
nealrichardson merged 4 commits into
apache:masterfrom
nealrichardson:r-upgrade-parquet

Conversation

nealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
Member

Also removes deprecated args to write_parquet()

github-actions Bot commented Jul 8, 2022

Copy link
Copy Markdown

https://issues.apache.org/jira/browse/ARROW-16715

github-actions Bot commented Jul 8, 2022

Copy link
Copy Markdown

⚠️ Ticket has not been started in JIRA, please click 'Start Progress'.

nealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit test-r-arrow-backwards-compatibility

github-actions Bot commented Jul 8, 2022

Copy link
Copy Markdown

Revision: f375949

Submitted crossbow builds: ursacomputing/crossbow @ actions-49cb752519

Task Status
test-r-arrow-backwards-compatibility

paleolimbot approved these changes Jul 8, 2022
View reviewed changes

paleolimbot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

A few lintr errors (I think I found them all + suggested the fix) but this looks good to me (The first CI failure appears to be the Array-subset-on-boolean error).

Comment thread r/tests/testthat/test-parquet.R Outdated
Comment thread r/tests/testthat/test-parquet.R Outdated
Comment thread r/tests/testthat/test-parquet.R Outdated
s/'/"/g
1776407 
Co-authored-by: Dewey Dunnington <dewey@fishandwhistle.net>

nealrichardson commented Jul 8, 2022

Copy link
Copy Markdown
Member Author

@jonkeane do you want to take a look at this? I seem to recall you set up the backwards compat testing.

jonkeane approved these changes Jul 11, 2022
View reviewed changes

jonkeane left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This looks good to me. I'm a little bit surprised that the backwards compatibility all the way back still is fine, but we must not test any types that have differed since the 2.0 version.

Comment thread r/tests/testthat/test-parquet.R
expect_equal(make_valid_version(2.0), ParquetVersionType$PARQUET_2_0)
test_that("make_valid_parquet_version() input validation", {
expect_error(
make_valid_parquet_version("0.3.14"),

jonkeane Jul 11, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

🥧

nealrichardson commented Jul 11, 2022

Copy link
Copy Markdown
Member Author

This looks good to me. I'm a little bit surprised that the backwards compatibility all the way back still is fine, but we must not test any types that have differed since the 2.0 version.

It may also be that the library can read whatever version file it receives (at least as far back as we test)

nealrichardson merged commit f0ff8d0 into apache:master Jul 11, 2022
nealrichardson deleted the r-upgrade-parquet branch July 11, 2022 15:26
eitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f 
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jonkeane jonkeane approved these changes
paleolimbot paleolimbot approved these changes

Assignees

No one assigned

Labels

Component: Documentation Component: Parquet Component: R

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL