FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ARROW-6364: [R] Handling unexpected input to time64() et al: by nealrichardson · Pull Request #5201 · apache/arrow · GitHub

/ arrow Public

ARROW-6364: [R] Handling unexpected input to time64() et al: - #5201

Closed
nealrichardson wants to merge 1 commit into
apache:masterfrom
nealrichardson:time-unit-validation
ConversationCommits (1)ChecksFiles changed
Closed

ARROW-6364: [R] Handling unexpected input to time64() et al:#5201
nealrichardson wants to merge 1 commit into
apache:masterfrom
nealrichardson:time-unit-validation

Conversation

nealrichardson commented Aug 26, 2019

Copy link
Copy Markdown
Member

This PR is based on #5198 (ARROW-6338) and is just one commit beyond that patch: 87209fb

codecov-io commented Aug 26, 2019

Copy link
Copy Markdown

Codecov Report

Merging #5201 into master will decrease coverage by 13.21%.
The diff coverage is 87.8%.

@@             Coverage Diff             @@
##           master    #5201       +/-   ##
===========================================
- Coverage   88.69%   75.47%   -13.22%     
===========================================
  Files         934       57      -877     
  Lines      121092     3649   -117443     
  Branches     1437        0     -1437     
===========================================
- Hits       107399     2754   -104645     
+ Misses      13331      895    -12436     
+ Partials      362        0      -362
Impacted Files Coverage Δ
r/R/feather.R 65.11% <ø> (ø) ⬆️
r/R/Table.R 88% <ø> (ø) ⬆️
r/R/csv.R 97.36% <ø> (ø) ⬆️
r/R/parquet.R 73.07% <ø> (ø) ⬆️
r/R/Column.R 0% <ø> (ø) ⬆️
r/R/RecordBatch.R 96.29% <ø> (ø) ⬆️
r/R/Struct.R 100% <ø> (ø) ⬆️
r/R/compression.R 92.3% <ø> (ø) ⬆️
r/R/RecordBatchWriter.R 70% <ø> (ø) ⬆️
r/R/ArrayData.R 20% <ø> (ø) ⬆️
... and 892 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9bd6d7...87209fb. Read the comment docs.

pitrou commented Aug 27, 2019

Copy link
Copy Markdown
Member

@nealrichardson You'll need to rebase and fix conflicts.

nealrichardson commented Aug 27, 2019

Copy link
Copy Markdown
Member Author

Rebased

pitrou reviewed Aug 27, 2019
View reviewed changes
Comment thread r/R/type.R
# Allow non-integer input for convenience
unit <- as.integer(unit)
} else {
stop('"unit" should be one of ', oxford_paste(names(valid_units), "or"), call.=FALSE)

pitrou Aug 27, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Is there a non-Oxford paste? :-)

nealrichardson Aug 27, 2019

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not for me ;)

(paste() is the vectorized R string concatenation function)

pitrou commented Aug 27, 2019

Copy link
Copy Markdown
Member

Travis: https://travis-ci.org/nealrichardson/arrow/builds/577377738
AppVeyor: https://ci.appveyor.com/project/nealrichardson/arrow/builds/26991639

pitrou approved these changes Aug 27, 2019
View reviewed changes

pitrou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

+1. Trusting @nealrichardson on this.

pitrou closed this in 31bdc0b Aug 27, 2019
asfimport mentioned this pull request Aug 27, 2019
Closed
eitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f 
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pitrou pitrou approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL