FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

ARROW-6337: [R] Changed as_tible to as_dataframe in the R package by jameslamb · Pull Request #5399 · apache/arrow · GitHub

/ arrow Public

ARROW-6337: [R] Changed as_tible to as_dataframe in the R package - #5399

Closed
jameslamb wants to merge 2 commits into
apache:masterfrom
jameslamb:as_dataframe
ConversationCommits (2)ChecksFiles changed
Closed

ARROW-6337: [R] Changed as_tible to as_dataframe in the R package#5399
jameslamb wants to merge 2 commits into
apache:masterfrom
jameslamb:as_dataframe

Conversation

jameslamb commented Sep 17, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

See ARROW-6337 for background on this PR.

codecov-io commented Sep 17, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@6d4f257). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master    #5399   +/-   ##
=========================================
  Coverage          ?   76.09%           
=========================================
  Files             ?       56           
  Lines             ?     3572           
  Branches          ?        0           
=========================================
  Hits              ?     2718           
  Misses            ?      854           
  Partials          ?        0
Impacted Files Coverage Δ
r/R/feather.R 63.33% <100%> (ø)
r/R/csv.R 100% <100%> (ø)
r/R/json.R 100% <100%> (ø)
r/R/parquet.R 66.66% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d4f257...66137bb. Read the comment docs.

nealrichardson requested changes Sep 17, 2019
View reviewed changes

nealrichardson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Acknowledging that naming things is hard, I'm not a fan of as_dataframe. That doesn't look right to me. I'd prefer as_data_frame, or even data_frame is better IMO--I'm not sure "as" adds any value.

What do you think?

jameslamb commented Sep 17, 2019

Copy link
Copy Markdown
Contributor Author

Acknowledging that naming things is hard, I'm not a fan of as_dataframe. That doesn't look right to me. I'd prefer as_data_frame, or even data_frame is better IMO--I'm not sure "as" adds any value.

What do you think?

IMO as_data_frame or return_data_frame is more informative than data_frame, so it's obvious in code that it isn't, for example, a flag used to allow you to pass in parse_options as a data frame instead of named list or something.

As long as we're keeping the "change output type with a flag" pattern, my preferences in order are:

  1. as_data_frame
  2. return_data_frame
  3. data_frame

I hold that opinion lightly though, and I'll defer to whatever you think is best on this one. Let me know what you'd like to do and I'd be happy to update the PR today!

nealrichardson commented Sep 17, 2019

Copy link
Copy Markdown
Member

Alright, then as_data_frame seems to be the compromise solution. Let's go with that.

jameslamb commented Sep 18, 2019

Copy link
Copy Markdown
Contributor Author

Alright, then as_data_frame seems to be the compromise solution. Let's go with that.

🤝 updated to as_data_frame and rebased to most recent master

nealrichardson commented Sep 18, 2019

Copy link
Copy Markdown
Member

+1, thanks!

asfimport mentioned this pull request Sep 18, 2019
Closed
eitsupi mentioned this pull request Feb 19, 2023
Merged
kou pushed a commit that referenced this pull request Feb 20, 2023
GH-33631: [R] Rewrite Jira ticket numbers in pkgdown documents to Git…
be40d9f 
…Hub issue numbers (#34260)

Rewrite the Jira issue numbers to the GitHub issue numbers, so that the GitHub issue numbers are automatically linked to the issues by pkgdown's auto-linking feature.

Issue numbers have been rewritten based on the following correspondence.
Also, the pkgdown settings have been changed and updated to link to GitHub.

I generated the Changelog page using the `pkgdown::build_news()` function and verified that the links work correctly.

---
ARROW-6338	#5198
ARROW-6364	#5201
ARROW-6323	#5169
ARROW-6278	#5141
ARROW-6360	#5329
ARROW-6533	#5450
ARROW-6348	#5223
ARROW-6337	#5399
ARROW-10850	#9128
ARROW-10624	#9092
ARROW-10386	#8549
ARROW-6994	#23308
ARROW-12774	#10320
ARROW-12670	#10287
ARROW-16828	#13484
ARROW-14989	#13482
ARROW-16977	#13514
ARROW-13404	#10999
ARROW-16887	#13601
ARROW-15906	#13206
ARROW-15280	#13171
ARROW-16144	#13183
ARROW-16511	#13105
ARROW-16085	#13088
ARROW-16715	#13555
ARROW-16268	#13550
ARROW-16700	#13518
ARROW-16807	#13583
ARROW-16871	#13517
ARROW-16415	#13190
ARROW-14821	#12154
ARROW-16439	#13174
ARROW-16394	#13118
ARROW-16516	#13163
ARROW-16395	#13627
ARROW-14848	#12589
ARROW-16407	#13196
ARROW-16653	#13506
ARROW-14575	#13160
ARROW-15271	#13170
ARROW-16703	#13650
ARROW-16444	#13397
ARROW-15016	#13541
ARROW-16776	#13563
ARROW-15622	#13090
ARROW-18131	#14484
ARROW-18305	#14581
ARROW-18285	#14615
* Closes: #33631

Authored-by: SHIMA Tatsuya <ts1s1andn@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
nealrichardson mentioned this pull request Apr 6, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

nealrichardson nealrichardson requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL