FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(apollo): [Data Collection 7] Apply incoming response body policy by adinauer · Pull Request #5803 · getsentry/sentry-java · GitHub

feat(apollo): [Data Collection 7] Apply incoming response body policy - #5803

Merged
adinauer merged 7 commits into
feat/data-collectionfrom
feat/data-collection-incoming-response-body
Sep 2, 2026
Merged

adinauer merged 7 commits into
feat/data-collectionfrom
feat/data-collection-incoming-response-body

Conversation

adinauer commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Member

PR Stack (Data Collection)


📜 Description

Apply the incoming response body policy to Apollo 3 and Apollo 4 failed GraphQL events.

When disabled, response body content is omitted while status code and body size remain attached. Existing always-collect behavior remains unchanged when Data Collection is absent.

💡 Motivation and Context

Apollo operates as an HTTP client, so received GraphQL response content maps to the incoming response body direction and should be independently configurable.

Refs #5666

💚 How did you test it?

  • ./gradlew spotlessApply apiDump
  • Apollo 3 and Apollo 4 failed-request tests

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Apply outgoing request and server response body policies.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Use the Data Collection incoming response body decision when attaching failed GraphQL response content in Apollo 3 and 4. Continue reading responses for error detection and retain status and body size metadata.

Co-Authored-By: Claude <noreply@anthropic.com>

github-actions Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 13f738d

sentry Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.48.0 (1) release

⚙️ sentry-android Build Distribution Settings

github-actions Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 306.92 ms 353.65 ms 46.74 ms
Size 0 B 0 B 0 B

Baseline results on branch: feat/data-collection-incoming-request-body

Startup times

Revision Plain With Sentry Diff
cc527d6 326.09 ms 381.02 ms 54.93 ms

App size

Revision Plain With Sentry Diff
cc527d6 0 B 0 B 0 B

Bring the queue option removal and preceding stack updates into this layer.

lbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Base automatically changed from feat/data-collection-incoming-request-body to feat/data-collection September 2, 2026 12:21
adinauer marked this pull request as ready for review September 2, 2026 12:22
adinauer merged commit 0d69665 into feat/data-collection Sep 2, 2026
70 of 73 checks passed
adinauer deleted the feat/data-collection-incoming-response-body branch September 2, 2026 12:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL