| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
Allow encoder-equipped Logback appenders to include original message templates and parameters without relying on sendDefaultPii. Keep sendDefaultPii as a temporary compatibility exception while Data Collection replaces its other behavior. Co-Authored-By: Claude <noreply@anthropic.com>
|
Sorry, something went wrong.
📲 Install BuildsAndroid
|
Sorry, something went wrong.
There was a problem hiding this comment.
Looks good. I won't block merging but worth taking a look at the kotlin synthetic properties.
Sorry, something went wrong.
| fixture = Fixture(minimumEventLevel = Level.DEBUG, includeUnencodedMessage = true) | ||
| fixture.logger.info("testing encoding {}", "param1") | ||
|
|
||
| assertThat(SentryAppender().isIncludeUnencodedMessage).isFalse() |
There was a problem hiding this comment.
Looks like we have a mismatch on the kotlin synthetic properties. I think renaming this to get would fix it.
Sorry, something went wrong.
| /** | ||
| * Whether to include the original message template and parameters when an encoder is configured. | ||
| */ | ||
| public boolean isIncludeUnencodedMessage() { |
There was a problem hiding this comment.
Based on the tests, it looks like we have a kotlin synthetic property mismatch. I think this should fix it. (see my comment below in the test)
| public boolean isIncludeUnencodedMessage() { | |
| public boolean getIncludeUnencodedMessage() { |
Sorry, something went wrong.
| @@ -177,7 +178,7 @@ protected void captureLog(@NotNull ILoggingEvent loggingEvent) { | |||
| final @NotNull String formattedMessage = formatted(loggingEvent); | |||
|
|
|||
| // if encoder is set we treat message+params as PII as encoders may be used to mask/strip PII | |||
There was a problem hiding this comment.
should we update the comment here (and on line 122) about includeUnencodedMessage ?
Sorry, something went wrong.
Describe how encoder use, the integration opt-in, and the legacy PII option control original message data. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
Align the includeUnencodedMessage getter and setter names so Kotlin exposes the option as a mutable synthetic property. Refs #5666 Co-Authored-By: Claude <noreply@anthropic.com>
| Back | FazBrowse Home | New Git URL |
PR Stack (Data Collection)
📜 Description
Add includeUnencodedMessage to the Logback SentryAppender. When an encoder is configured, this explicit integration option includes the original message template and parameters alongside the encoded output.
Keep sendDefaultPii=true as a temporary compatibility opt-in, including when Data Collection is configured. Without an encoder, the appender preserves its existing behavior and includes the original message data.
💡 Motivation and Context
Logback encoders can mask or remove PII before Sentry receives the formatted message. The existing guard relies only on the broad legacy sendDefaultPii option. This adds a narrow Logback-specific opt-in without introducing a Data Collection category for raw log messages.
Refs #5666
💚 How did you test it?
📝 Checklist
🔮 Next steps
Merge this PR into the previous stack branch before merging the remaining Data Collection stack into the collection branch.
#skip-changelog