FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

feat(graphql): [Data Collection 9] Apply outgoing response body policy by adinauer · Pull Request #5805 · getsentry/sentry-java · GitHub

feat(graphql): [Data Collection 9] Apply outgoing response body policy - #5805

Merged
adinauer merged 7 commits into
feat/data-collectionfrom
feat/data-collection-outgoing-response-body
Sep 2, 2026
Merged

adinauer merged 7 commits into
feat/data-collectionfrom
feat/data-collection-outgoing-response-body

Conversation

adinauer commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Member

PR Stack (Data Collection)


📜 Description

Apply the outgoing response body policy to GraphQL Java execution results attached by ExceptionReporter.

Explicit Data Collection controls the serialized GraphQL response independently from the request document. When Data Collection is absent, the existing sendDefaultPii and maxRequestBodySize gate remains unchanged.

💡 Motivation and Context

A server-side GraphQL execution result is outgoing response body content and can contain customer data. It requires a directional policy distinct from the incoming GraphQL document and variables.

Refs #5666

💚 How did you test it?

  • ./gradlew spotlessApply apiDump
  • DataCollectionResolverTest
  • ExceptionReporterTest
  • ./gradlew apiCheck

📝 Checklist

  • I added GH Issue ID & Linear ID
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Apply request and response header collection behavior across HTTP integrations.

#skip-changelog

⚠️ Merge this PR using a merge commit (not squash). Only the collection branch is squash-merged into main.

Use the Data Collection outgoing response body decision when attaching GraphQL execution results. Preserve the sendDefaultPii and maxRequestBodySize gate when Data Collection is absent.

Co-Authored-By: Claude <noreply@anthropic.com>

github-actions Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Contributor
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against b884d74

sentry Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown

📲 Install Builds

Android

🔗 App Name App ID Version Configuration
SDK Size io.sentry.tests.size 8.48.0 (1) release

⚙️ sentry-android Build Distribution Settings

github-actions Bot commented Jul 21, 2026
edited
Loading

Copy link
Copy Markdown
Contributor

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 363.44 ms 441.58 ms 78.14 ms
Size 0 B 0 B 0 B

Bring the queue option removal and preceding stack updates into this layer.

lbloder left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM 👍

Copy link
Copy Markdown
Contributor

Semver Impact of This PR

🟡 Minor (new features)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


This PR will not appear in the changelog.


🤖 This preview updates automatically when you update the PR.

Base automatically changed from feat/data-collection-outgoing-request-body to feat/data-collection September 2, 2026 12:22
adinauer marked this pull request as ready for review September 2, 2026 12:23
adinauer merged commit b86cbff into feat/data-collection Sep 2, 2026
69 of 73 checks passed
adinauer deleted the feat/data-collection-outgoing-response-body branch September 2, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants


Back | FazBrowse Home | New Git URL