bigquery: simplify query types by pongad · Pull Request #2653 · googleapis/google-cloud-java · GitHub

Updates #2591.

Previous PR, #2642, broke Job.getQueryResults in two ways:

It wasn't possible to get total number of rows.
The returned iterator doesn't record schema, so it wasn't possible
to call row.get(String).

This PR prepares the fix.
Actually landing the fix will change tests,
so it is punted to another PR to keep changes small.

From previous meeting, it was our decision to remove

BigQuery.getQueryResults method
QueryResponse class

However, the method is being used internally by the client,
and interfaces only have public members.
Removing them altogether entails a big surgery,
so this PR instead mark them @internalapi.

Updates #2591. Previous PR, #2642, broke Job.getQueryResults in two ways: 1. It wasn't possible to get total number of rows. 2. The returned iterator doesn't record schema, so it wasn't possible to call `row.get(String)`. This PR prepares the fix. Actually landing the fix will change tests, so it is punted to another PR to keep changes small. From previous meeting, it was our decision to remove - BigQuery.getQueryResults method - QueryResponse class However, the method is being used internally by the client, and interfaces only have public members. Removing them altogether entails a big surgery, so this PR instead mark them @internalapi.

update gapic-showcase so that we can pickup changes in googleapis/gapic-showcase#1484 Steps: 1) Updated the gapic-showcase version in `gapic-showcase/pom.xml` to 0.33.0 2) Ran `mvn compile -P update`

* chore: modify readme's transport support description * chore: generate libraries at Wed Jul 31 02:31:45 UTC 2024 --------- Co-authored-by: cloud-java-bot <cloud-java-bot@google.com>

googleapis#2653) This pull request is generated with proto changes between [googleapis/googleapis@b031657](https://togithub.com/googleapis/googleapis/commit/b0316578aaf7434e3c5bb93badd252f67aacf8d5) (exclusive) and [googleapis/googleapis@6821943](https://togithub.com/googleapis/googleapis/commit/6821943108fe3284f483defc9b60774a3752de2b) (inclusive). BEGIN_COMMIT_OVERRIDE BEGIN_NESTED_COMMIT fix(deps): update the Java code generator (gapic-generator-java) to 2.62.3 END_NESTED_COMMIT BEGIN_NESTED_COMMIT chore: update the libraries_bom version to 26.70.0 END_NESTED_COMMIT BEGIN_NESTED_COMMIT feat: Add Type API updates needed to support structured keys in materialized views feat: Add encodings for STRUCT and the Timestamp type PiperOrigin-RevId: 805031861 Source Link: [googleapis/googleapis@6d1dca2](https://togithub.com/googleapis/googleapis/commit/6d1dca2b8e3d50914609414e219df2778b2b20ba) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: Fixed the bigtableadmin API name for snippet region tags and possibly other GAPIC attributes PiperOrigin-RevId: 797086089 Source Link: [googleapis/googleapis@3b2a2ae](https://togithub.com/googleapis/googleapis/commit/3b2a2ae91db23a9c879b2b725d6a5de6bd64a800) END_NESTED_COMMIT BEGIN_NESTED_COMMIT fix: Add ReadRows/SampleRowKeys bindings for materialized views PiperOrigin-RevId: 793800781 Source Link: [googleapis/googleapis@fe06a49](https://togithub.com/googleapis/googleapis/commit/fe06a492944dc3a8360ed5b426942d34631eeca7) END_NESTED_COMMIT END_COMMIT_OVERRIDE

pongad requested a review from tswast November 22, 2017 09:45

pongad requested a review from garrettjonesgoogle as a code owner November 22, 2017 09:45

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2017

pongad commented Nov 22, 2017

View reviewed changes

tswast approved these changes Nov 22, 2017

View reviewed changes

pongad added 2 commits November 23, 2017 17:28

pr comment

1184fc9

fix links

ecdfb3e

pongad merged commit 6faec8f into googleapis:bq-perf Nov 23, 2017

pongad deleted the bq-response branch November 23, 2017 07:02

                   // TODO(pongad): return QueryResult so we can inject schema.
+                  // QueryResponse response = bigquery.getQueryResults(getJobId()); // should return immediately
+                  // return new QueryResult(response.getSchema(), response.getTotalRows(), bigquery.listTableData(table));
                   return bigquery.listTableData(table);

bigquery: simplify query types by pongad · Pull Request #2653 · googleapis/google-cloud-java · GitHub

Uh oh!

bigquery: simplify query types - #2653

bigquery: simplify query types#2653
pongad merged 3 commits into
googleapis:bq-perffrom
pongad:bq-response

pongad commented Nov 22, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

               import java.util.Objects;
-              public class QueryResult extends PageImpl<FieldValueList> {
+              // TODO(pongad): Serializable ?

+                private final Page<FieldValueList> pageNoSchema;
+                private final Function<FieldValueList, FieldValueList> addSchemaFunc;
+                QueryResult(final Schema schema, long totalRows, Page<FieldValueList> pageNoSchema) {

bigquery: simplify query types by pongad · Pull Request #2653 · googleapis/google-cloud-java · GitHub

Uh oh!

bigquery: simplify query types - #2653

bigquery: simplify query types#2653pongad merged 3 commits intogoogleapis:bq-perfgoogleapis/google-cloud-java:bq-perffrom pongad:bq-responseCopy head branch name to clipboard

Conversation

pongad commented Nov 22, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

bigquery: simplify query types#2653
pongad merged 3 commits into
googleapis:bq-perffrom
pongad:bq-response