Creating BOM (google-cloud-bom) - #2679
Merged
garrettjonesgoogle merged 9 commits intoDec 8, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
vam-google
reviewed
Dec 5, 2017
vam-google
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Few more things:
- Please check that the build scripts still work (especially update_versions.sh).
- It seems there are still some "forgotten" direct dependencies scattered across different poms in this repo. For example:
2.1) Direct apiary dependencies, like v2-rev347-1.22.0 in google-cloud-bigquery pom
2.2) Random stuff like json version 20160810 in google-cloud-core pom - (Optional) We probably also need to clean up our plugins version using same tool: pluginManagement section.
Sorry, something went wrong.
Comment thread
pom.xml
Outdated
| <version>${gax-grpc.version}</version> | ||
| <classifier>testlib</classifier> | ||
| <artifactId>google-cloud-dependencies</artifactId> | ||
| <version>${google-cloud-parent.version}</version> |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
google-cloud-dependencies/pom.xml
| @@ -0,0 +1,810 @@ | |||
| <?xml version="1.0"?> | |||
This comment was marked as spam.
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
I have addressed feedback and verified that update_versions.sh works. PTAL |
Sorry, something went wrong.
vam-google
reviewed
Dec 7, 2017
vam-google
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry I should have mentioned in the first review iteration: the test dependencies should be separated from the others (probably two boms?). The fact that test deps are also in the "bom" was the main argument against using parent pom as bom.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I agree with the comment you made in #2332 , that it's good to have compile and test dependencies versioned together. I think we can consider pulling out test deps as a later cleanup. Anyway, Spring (our spiritual leader in this matter) has both compile and test deps together: https://github.com/spring-io/platform/blob/master/platform-bom/pom.xml . |
Sorry, something went wrong.
Most of these tests are moved to `MessageDispatcherTest`. `isStreaming` is dead because only tests left here tests streaming, so it's always true. The special logic in `MessageReceiver` is dead because no test depends on that logic anymore.
Copy link
Copy Markdown
Contributor
Author
|
I have moved pure test dependencies back to the main pom.xml, PTAL |
Sorry, something went wrong.
vam-google
approved these changes
Dec 7, 2017
vam-google
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
|
This needs documentation that shows how to use the BOM (with Maven at least, also possible with Gradle with a special plugin), which version of the BOM to use, etc. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
chingor13
pushed a commit
that referenced
this pull request
Feb 20, 2026
…-config (#2679) These dependencies were added in #2388 with hardcoded versions. We prefer getting these versions from sdk-platform-java-config (includes both auth and gax versions). auth is included in dependencyManagement here in gapic-generator-java-bom, which is part of first-party-dependencies, and eventually included via sdk-platform-java-config.
chingor13
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- <details><summary>2.40.0</summary> ## [2.40.0](googleapis/sdk-platform-java@v2.39.0...v2.40.0) (2024-05-02) ### Features * [common-protos] add `Weight` to common types for Shopping APIs to be used for accounts bundle ([#2699](googleapis/sdk-platform-java#2699)) ([90a28ef](googleapis/sdk-platform-java@90a28ef)) * add a CLI tool to validate generation configuration ([#2691](googleapis/sdk-platform-java#2691)) ([f52f8cc](googleapis/sdk-platform-java@f52f8cc)) * Parser to consume the api-versioning value from proto ([#2630](googleapis/sdk-platform-java#2630)) ([c112b37](googleapis/sdk-platform-java@c112b37)) * Update Gapic generator and Gax to emit api-versioning via header ([#2671](googleapis/sdk-platform-java#2671)) ([cb5ada0](googleapis/sdk-platform-java@cb5ada0)) ### Bug Fixes * change folder prefix for adding headers ([#2688](googleapis/sdk-platform-java#2688)) ([ab5ba1d](googleapis/sdk-platform-java@ab5ba1d)) * Log HttpJson's async thread pool core size ([#2697](googleapis/sdk-platform-java#2697)) ([31038d1](googleapis/sdk-platform-java@31038d1)) * replace `cfg = "host"` with `cfg = "exec"` ([#2637](googleapis/sdk-platform-java#2637)) ([fd12e0f](googleapis/sdk-platform-java@fd12e0f)) * Return resolved endpoint from StubSettings' Builder ([#2715](googleapis/sdk-platform-java#2715)) ([6139a73](googleapis/sdk-platform-java@6139a73)) ### Dependencies * Make opentelemetry-api an optional dependency. ([#2681](googleapis/sdk-platform-java#2681)) ([2239c8c](googleapis/sdk-platform-java@2239c8c)) * update dependency absl-py to v2.1.0 ([#2659](googleapis/sdk-platform-java#2659)) ([b2b7738](googleapis/sdk-platform-java@b2b7738)) * update dependency gitpython to v3.1.43 ([#2656](googleapis/sdk-platform-java#2656)) ([6d273ad](googleapis/sdk-platform-java@6d273ad)) * update dependency lxml to v5.2.1 ([#2661](googleapis/sdk-platform-java#2661)) ([7a34168](googleapis/sdk-platform-java@7a34168)) * update dependency net.bytebuddy:byte-buddy to v1.14.14 ([#2703](googleapis/sdk-platform-java#2703)) ([72b0441](googleapis/sdk-platform-java@72b0441)) * update dependency typing to v3.10.0.0 ([#2663](googleapis/sdk-platform-java#2663)) ([4c64e98](googleapis/sdk-platform-java@4c64e98)) * update gapic-showcase to v0.33.0 ([#2653](googleapis/sdk-platform-java#2653)) ([5c12155](googleapis/sdk-platform-java@5c12155)) ### Documentation * Add contributing guidelines to PR and issue templates ([#2682](googleapis/sdk-platform-java#2682)) ([82f5ce8](googleapis/sdk-platform-java@82f5ce8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
meltsufin
pushed a commit
that referenced
this pull request
Apr 29, 2026
meltsufin
pushed a commit
that referenced
this pull request
May 1, 2026
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
rahul2393
pushed a commit
to akash329d/google-cloud-java
that referenced
this pull request
May 21, 2026
🤖 I have created a release *beep* *boop* --- ## [2.67.0](https://togithub.com/googleapis/java-bigtable/compare/v2.66.0...v2.67.0) (2025-09-24) ### Features * Idle channel eviction ([googleapis#2651](https://togithub.com/googleapis/java-bigtable/issues/2651)) ([f57656f](https://togithub.com/googleapis/java-bigtable/commit/f57656f6b3e0e3361679343f291c645e67cdda6b)) * Load balancing options for BigtableChannelPool ([googleapis#2667](https://togithub.com/googleapis/java-bigtable/issues/2667)) ([18d6ff3](https://togithub.com/googleapis/java-bigtable/commit/18d6ff3f45fbd0cc0f45b6c72e84f2f61cd3bca2)) ### Bug Fixes * Add missing break; to PROTO and ENUM value type check ([googleapis#2672](https://togithub.com/googleapis/java-bigtable/issues/2672)) ([5761dca](https://togithub.com/googleapis/java-bigtable/commit/5761dca060beb802ab8efedb7bd49e614a56e89c)) * Remove beta api annotation for query paginator ([googleapis#2660](https://togithub.com/googleapis/java-bigtable/issues/2660)) ([f8875ae](https://togithub.com/googleapis/java-bigtable/commit/f8875ae70a66be0d8c611419a15bb71c944b07ec)) ### Dependencies * Update shared dependencies ([googleapis#2679](https://togithub.com/googleapis/java-bigtable/issues/2679)) ([d76504c](https://togithub.com/googleapis/java-bigtable/commit/d76504c8b2620aee627368ed16e5274a07ac0db6)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2307