FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: update gapic-showcase to v0.33.0 by zhumin8 · Pull Request #2653 · googleapis/sdk-platform-java · GitHub

This repository was archived by the owner on May 14, 2026. It is now read-only.
/ sdk-platform-java Public archive

deps: update gapic-showcase to v0.33.0 - #2653

Merged
zhumin8 merged 3 commits into
mainfrom
update-showcase
Apr 22, 2024
ConversationCommits (3)ChecksFiles changed
Merged

deps: update gapic-showcase to v0.33.0#2653
zhumin8 merged 3 commits into
mainfrom
update-showcase

Conversation

zhumin8 commented Apr 17, 2024

Copy link
Copy Markdown
Contributor

update gapic-showcase so that we can pickup changes in googleapis/gapic-showcase#1484

Steps:

  1. Updated the gapic-showcase version in gapic-showcase/pom.xml to 0.33.0
  2. Ran mvn compile -P update

zhumin8 requested a review from a team April 17, 2024 20:15
product-auto-label Bot added the size: l Pull request size is large. label Apr 17, 2024
zhumin8 requested review from alicejli and lqiu96 April 17, 2024 20:19

sonarqubecloud Bot commented Apr 17, 2024

Copy link
Copy Markdown

Quality Gate failed for 'gapic-generator-java-root'

Failed conditions
1.9% Coverage on New Code (required ≥ 80%)
60.4% Duplication on New Code (required ≤ 3%)
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

sonarqubecloud Bot commented Apr 17, 2024

Copy link
Copy Markdown

Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
50.0% Duplication on New Code

See analysis details on SonarCloud

lqiu96 commented Apr 17, 2024

Copy link
Copy Markdown
Member

@burkedavison Do you remember what this showcase version value in the WORKSPACE file is for? https://github.com/googleapis/sdk-platform-java/blob/main/WORKSPACE#L110

Do we need to keep this updated/ is this used at all?

zhumin8 commented Apr 17, 2024

Copy link
Copy Markdown
Contributor Author

2 failed cis:

  • showcase-clirr - okay to ignore according to deps: update gapic-showcase to v0.30.0 #2354 (comment)
  • [gapic-generator-java-root] sonarcloud.
    • For coverage on new code, other than api-version, most changes comes from proto change related to request-id. cc. @alicejli for context.
    • For duplication and reliability, consider these are generated code, Wonder what's our general approach here? cc. @lqiu96 @blakeli0

lqiu96 commented Apr 17, 2024

Copy link
Copy Markdown
Member

For duplication and reliability, consider these are generated code, Wonder what's our general approach here?

I think it's fine for us to merge it in. We can't change the protoc generated code and the generated output from the gapic-generator probably needs a larger refactor to "fix".

blakeli0 commented Apr 18, 2024

Copy link
Copy Markdown
Contributor

@burkedavison Do you remember what this showcase version value in the WORKSPACE file is for? https://github.com/googleapis/sdk-platform-java/blob/main/WORKSPACE#L110

Do we need to keep this updated/ is this used at all?

I think we can probably remove the showcase section in WORKSPACE, we used to use Bazel to generate showcase client, but now we use hermetic build scripts, and the version is greped from the pom.

zhumin8 commented Apr 22, 2024

Copy link
Copy Markdown
Contributor Author

@blakeli0 @lqiu96 Could you take another look?
I'd like to merge this in if it looks good.

lqiu96 approved these changes Apr 22, 2024
View reviewed changes

lqiu96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, thanks!

zhumin8 merged commit 0a71cbf into main Apr 22, 2024
zhumin8 deleted the update-showcase branch April 22, 2024 20:08
release-please Bot mentioned this pull request Apr 22, 2024
Merged
alicejli pushed a commit that referenced this pull request May 2, 2024
chore(main): release 2.40.0 (#2679)
42251c3 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](#2699))
([5bb9770](5bb9770))
* add a CLI tool to validate generation configuration
([#2691](#2691))
([f2ce524](f2ce524))
* Parser to consume the api-versioning value from proto
([#2630](#2630))
([40711fd](40711fd))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](#2671))
([e63d1b4](e63d1b4))


### Bug Fixes

* change folder prefix for adding headers
([#2688](#2688))
([4e92be8](4e92be8))
* Log HttpJson's async thread pool core size
([#2697](#2697))
([34b4bc3](34b4bc3))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](#2637))
([6d673f3](6d673f3))
* Return resolved endpoint from StubSettings' Builder
([#2715](#2715))
([32c9995](32c9995))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](#2681))
([3967a19](3967a19))
* update dependency absl-py to v2.1.0
([#2659](#2659))
([cae6d79](cae6d79))
* update dependency gitpython to v3.1.43
([#2656](#2656))
([208bef4](208bef4))
* update dependency lxml to v5.2.1
([#2661](#2661))
([b95ad49](b95ad49))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](#2703))
([87069bc](87069bc))
* update dependency typing to v3.10.0.0
([#2663](#2663))
([7fb5653](7fb5653))
* update gapic-showcase to v0.33.0
([#2653](#2653))
([0a71cbf](0a71cbf))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](#2682))
([42526dc](42526dc))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
lqiu96 pushed a commit that referenced this pull request May 22, 2024
deps: update gapic-showcase to v0.33.0 (#2653)
5227cd9 
update gapic-showcase so that we can pickup changes in
googleapis/gapic-showcase#1484

Steps: 
1) Updated the gapic-showcase version in `gapic-showcase/pom.xml` to
0.33.0
2) Ran `mvn compile -P update`
lqiu96 pushed a commit that referenced this pull request May 22, 2024
chore(main): release 2.40.0 (#2679)
00f7d9c 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](#2699))
([5bb9770](5bb9770))
* add a CLI tool to validate generation configuration
([#2691](#2691))
([f2ce524](f2ce524))
* Parser to consume the api-versioning value from proto
([#2630](#2630))
([40711fd](40711fd))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](#2671))
([e63d1b4](e63d1b4))


### Bug Fixes

* change folder prefix for adding headers
([#2688](#2688))
([4e92be8](4e92be8))
* Log HttpJson's async thread pool core size
([#2697](#2697))
([34b4bc3](34b4bc3))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](#2637))
([6d673f3](6d673f3))
* Return resolved endpoint from StubSettings' Builder
([#2715](#2715))
([32c9995](32c9995))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](#2681))
([3967a19](3967a19))
* update dependency absl-py to v2.1.0
([#2659](#2659))
([cae6d79](cae6d79))
* update dependency gitpython to v3.1.43
([#2656](#2656))
([208bef4](208bef4))
* update dependency lxml to v5.2.1
([#2661](#2661))
([b95ad49](b95ad49))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](#2703))
([87069bc](87069bc))
* update dependency typing to v3.10.0.0
([#2663](#2663))
([7fb5653](7fb5653))
* update gapic-showcase to v0.33.0
([#2653](#2653))
([0a71cbf](0a71cbf))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](#2682))
([42526dc](42526dc))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
chingor13 pushed a commit to googleapis/google-cloud-java that referenced this pull request Mar 24, 2026
chore(main): release 2.40.0 (#2679)
32ebbe1 
🤖 I have created a release *beep* *boop*
---


<details><summary>2.40.0</summary>

##
[2.40.0](googleapis/sdk-platform-java@v2.39.0...v2.40.0)
(2024-05-02)


### Features

* [common-protos] add `Weight` to common types for Shopping APIs to be
used for accounts bundle
([#2699](googleapis/sdk-platform-java#2699))
([90a28ef](googleapis/sdk-platform-java@90a28ef))
* add a CLI tool to validate generation configuration
([#2691](googleapis/sdk-platform-java#2691))
([f52f8cc](googleapis/sdk-platform-java@f52f8cc))
* Parser to consume the api-versioning value from proto
([#2630](googleapis/sdk-platform-java#2630))
([c112b37](googleapis/sdk-platform-java@c112b37))
* Update Gapic generator and Gax to emit api-versioning via header
([#2671](googleapis/sdk-platform-java#2671))
([cb5ada0](googleapis/sdk-platform-java@cb5ada0))


### Bug Fixes

* change folder prefix for adding headers
([#2688](googleapis/sdk-platform-java#2688))
([ab5ba1d](googleapis/sdk-platform-java@ab5ba1d))
* Log HttpJson's async thread pool core size
([#2697](googleapis/sdk-platform-java#2697))
([31038d1](googleapis/sdk-platform-java@31038d1))
* replace `cfg = "host"` with `cfg = "exec"`
([#2637](googleapis/sdk-platform-java#2637))
([fd12e0f](googleapis/sdk-platform-java@fd12e0f))
* Return resolved endpoint from StubSettings' Builder
([#2715](googleapis/sdk-platform-java#2715))
([6139a73](googleapis/sdk-platform-java@6139a73))


### Dependencies

* Make opentelemetry-api an optional dependency.
([#2681](googleapis/sdk-platform-java#2681))
([2239c8c](googleapis/sdk-platform-java@2239c8c))
* update dependency absl-py to v2.1.0
([#2659](googleapis/sdk-platform-java#2659))
([b2b7738](googleapis/sdk-platform-java@b2b7738))
* update dependency gitpython to v3.1.43
([#2656](googleapis/sdk-platform-java#2656))
([6d273ad](googleapis/sdk-platform-java@6d273ad))
* update dependency lxml to v5.2.1
([#2661](googleapis/sdk-platform-java#2661))
([7a34168](googleapis/sdk-platform-java@7a34168))
* update dependency net.bytebuddy:byte-buddy to v1.14.14
([#2703](googleapis/sdk-platform-java#2703))
([72b0441](googleapis/sdk-platform-java@72b0441))
* update dependency typing to v3.10.0.0
([#2663](googleapis/sdk-platform-java#2663))
([4c64e98](googleapis/sdk-platform-java@4c64e98))
* update gapic-showcase to v0.33.0
([#2653](googleapis/sdk-platform-java#2653))
([5c12155](googleapis/sdk-platform-java@5c12155))


### Documentation

* Add contributing guidelines to PR and issue templates
([#2682](googleapis/sdk-platform-java#2682))
([82f5ce8](googleapis/sdk-platform-java@82f5ce8))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

alicejli Awaiting requested review from alicejli
1 more reviewer
lqiu96 lqiu96 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size: l Pull request size is large.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL