Add operation future - #3618
Merged
theacodes merged 4 commits intoJul 19, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
theacodes
commented
Jul 17, 2017
Comment thread
core/google/cloud/future/operation.py
|
|
||
| Args: | ||
| operation (dict): Operation as a dictionary. | ||
| api_request (Callable): A callable used to make an API request. This |
This comment was marked as spam.
This comment was marked as spam.
lukesneeringer
approved these changes
Jul 17, 2017
lukesneeringer
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
This seems fine to me. No issues adding tenacity.
Sorry, something went wrong.
This was referenced Jul 18, 2017
dhermes
reviewed
Jul 18, 2017
dhermes
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
High-level: Do LRO RPC services give trailers describing when to retry?
Sorry, something went wrong.
Comment thread
core/setup.py
| 'google-auth >= 0.4.0, < 2.0.0dev', | ||
| 'google-auth-httplib2', | ||
| 'six', | ||
| 'tenacity >= 4.0.0, <5.0.0dev' |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
| """Abstract and helper bases for Future implementations.""" | ||
|
|
||
| import abc | ||
| import concurrent.futures |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
Outdated
|
|
||
| The private :meth:`_blocking_poll` method should be implemented by | ||
| subclasses. | ||
| The private :meth:`done` method should be implemented by |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
| """ | ||
| # pylint: disable=missing-raises | ||
| raise NotImplementedError() | ||
| if self._result_set: |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/base.py
Outdated
| if self._result_set: | ||
| return | ||
|
|
||
| retry_on = tenacity.retry_if_result(lambda result: result is not True) |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/operation.py
Outdated
| self.set_exception(exception) | ||
| else: | ||
| exception = exceptions.GoogleCloudError( | ||
| 'Unknown operation error') |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/operation.py
Outdated
| bool: True if the operation is complete, False otherwise. | ||
| """ | ||
| operation = self._refresh_and_update() | ||
| return operation.done |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/operation.py
|
|
||
| Args: | ||
| operation (dict): Operation as a dictionary. | ||
| api_request (Callable): A callable used to make an API request. This |
This comment was marked as spam.
Comment thread
core/google/cloud/future/operation.py
Outdated
| Args: | ||
| operation (dict): Operation as a dictionary. | ||
| api_request (Callable): A callable used to make an API request. This | ||
| should generally be an instance of |
This comment was marked as spam.
This comment was marked as spam.
Comment thread
core/google/cloud/future/operation.py
Outdated
| to a given API) vis `HTTP/JSON`_. | ||
|
|
||
| .. _HTTP/JSON: https://cloud.google.com/speech/reference/rest/\ | ||
| v1beta1/operations#Operation |
This comment was marked as spam.
This comment was marked as spam.
dhermes
reviewed
Jul 18, 2017
Comment thread
core/google/cloud/future/operation.py
| exception = exceptions.GoogleCloudError( | ||
| 'Unknown operation error') | ||
| 'Unexpected state: Long-running operation had neither ' | ||
| 'response nor error set.') |
This comment was marked as spam.
Copy link
Copy Markdown
Contributor
Author
|
@dhermes the latest release of resumable-media seems to have broken circle. Do you want me to hold off on merging this until you can resolve that? (Master will be broken by it either way). |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
Rebased and waiting on CI to merge. |
Sorry, something went wrong.
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 21, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
landrito
pushed a commit
to landrito/google-cloud-python
that referenced
this pull request
Aug 22, 2017
parthea
pushed a commit
that referenced
this pull request
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
2 more reviewers4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This adds a dependency on the tenacity library. It's worth it.
Towards #3617