This repository was archived by the owner on Jun 8, 2026. It is now read-only.
fix: avoid bad version of opentelemetry-instrumentation - #429
Merged
tseaver merged 4 commits intoJul 28, 2021
Merged
tseaver merged 4 commits into
tseaver merged 4 commits into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
tseaver
suggested changes
Jul 27, 2021
tseaver
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
The main change here (in setup.py looks fine).
For the testing/constraints-x.y.txt files, the pattern in other libraries is to have the one associated with the lowest supported Python version (i.e, testing/constraints-3.x.txt) pin all the minimum dependencies, so that the library gets tested against them, but leave them unpinned for the higher supported versions (so that we continue to test against current versions).
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@tseaver The test pass locally with the change but the CI is still failing 😕 Any ideas? This is blocking all PRs |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@larkee I'm puzzled. Can you tweak noxfile to show the installed version of opentelemetry-instrumenation, e.g.: session.run("pip", "show", "opentelemetry-instrumentation")I'm seeing this locally, and it fails: Name: opentelemetry-instrumentation Version: 0.23b2 Summary: Instrumentation Tools & Auto Instrumentation for OpenTelemetry Python Home-page: https://github.com/open-telemetry/opentelemetry-python-contrib/tree/main/opentelemetry-instrumentation Author: OpenTelemetry Authors Author-email: cncf-opentelemetry-contributors@lists.cncf.io License: Apache-2.0 Location: /home/tseaver/projects/agendaless/Google/src/python-spanner/.nox/unit-3-9/lib/python3.9/site-packages Requires: opentelemetry-api, wrapt Required-by: opentelemetry-sdk |
Sorry, something went wrong.
tseaver
suggested changes
Jul 28, 2021
Comment thread
setup.py
Outdated
Merged
Versions after `0.23b0` are now released, and still break us.
tseaver
approved these changes
Jul 28, 2021
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jul 30, 2021
🤖 I have created a release \*beep\* \*boop\* --- ## [3.7.0](https://www.github.com/googleapis/python-spanner/compare/v3.6.0...v3.7.0) (2021-07-29) ### Features * add always_use_jwt_access ([#381](https://www.github.com/googleapis/python-spanner/issues/381)) ([0f1a5de](https://www.github.com/googleapis/python-spanner/commit/0f1a5ded572685a96d29a60c959cb00a48f7a87f)) * add configurable leader placement support ([#399](https://www.github.com/googleapis/python-spanner/issues/399)) ([7f1b120](https://www.github.com/googleapis/python-spanner/commit/7f1b1209e62062014545cf959d41f04184552eec)) * add sample for low cost instances ([#392](https://www.github.com/googleapis/python-spanner/issues/392)) ([3f4f93f](https://www.github.com/googleapis/python-spanner/commit/3f4f93f75f5585a82047bf8d83a24622ad776ecb)) ### Bug Fixes * avoid bad version of `opentelemetry-instrumentation` ([#429](https://www.github.com/googleapis/python-spanner/issues/429)) ([1620c12](https://www.github.com/googleapis/python-spanner/commit/1620c12a56e0d007cf010690bab303db06d0c914)) * **deps:** pin 'google-{api,cloud}-core' to allow 2.x versions ([#415](https://www.github.com/googleapis/python-spanner/issues/415)) ([b0455d0](https://www.github.com/googleapis/python-spanner/commit/b0455d0ab657cd053a7527e99bdbfadc4de23b30)) * disable always_use_jwt_access ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad)) * disable always_use_jwt_access ([#395](https://www.github.com/googleapis/python-spanner/issues/395)) ([c37bf21](https://www.github.com/googleapis/python-spanner/commit/c37bf21afdf417757eff67fe8500aa65f49fd5ad)) * enable self signed jwt for grpc ([#427](https://www.github.com/googleapis/python-spanner/issues/427)) ([2487800](https://www.github.com/googleapis/python-spanner/commit/2487800e31842a44dcc37937c325e130c8c926b0)) * support merging for NUMERIC values ([#434](https://www.github.com/googleapis/python-spanner/issues/434)) ([06b4215](https://www.github.com/googleapis/python-spanner/commit/06b4215f76ae806eba1d0d07115c8c90b8c7482d)), closes [#433](https://www.github.com/googleapis/python-spanner/issues/433) ### Documentation * fix docstring for session.py ([#387](https://www.github.com/googleapis/python-spanner/issues/387)) ([3132587](https://www.github.com/googleapis/python-spanner/commit/3132587453f7bd0be72ebc393626b5c8b1bab982)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reviewers
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 0.23b0 of opentelemetry-instrumentation is causing unit tests failure relating to opentelemetry assertions. This PR updated the google-cloud-spanner dependency to avoid this particular version.