FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

chore: Code refactoring to follow common Google API scheme by mf2199 · Pull Request #482 · googleapis/python-spanner-django · GitHub

This repository was archived by the owner on Jun 8, 2026. It is now read-only.

chore: Code refactoring to follow common Google API scheme - #482

Closed
mf2199 wants to merge 26 commits into
googleapis:masterfrom
MaxxleLLC:refactor
Closed

mf2199 wants to merge 26 commits into
googleapis:masterfrom
MaxxleLLC:refactor

Conversation

mf2199 commented Sep 7, 2020
edited
Loading

Copy link
Copy Markdown
Contributor

Change list:

  1. django_spanner folder renamed to spanner_django and moved inside google/cloud/;
  2. spanner_dbapi folder moved inside google/cloud/;
  3. Invalidated references updated to reflect the above changes;
  4. Relevant updates to noxfile.py.

While working on the build errors, this PR is kept as a draft.

google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 7, 2020
mf2199 requested review from IlyaFaer, c24t and paul1319 September 7, 2020 22:59
product-auto-label Bot added the api: spanner Issues related to the googleapis/python-spanner-django API. label Sep 8, 2020

IlyaFaer left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks okay

c24t commented Sep 8, 2020

Copy link
Copy Markdown
Contributor

This PR changes the distribution name from django-google-spanner to google-cloud-spanner-django to match the other googleapis projects. Thankfully this project hasn't been released on PyPI yet, so we don't have to worry about deprecating the old name.

It also changes the package namespace. Now instead of a single top-level django_spanner we've got two new namespaces under the shared google.cloud: google.cloud.spanner_django and google.cloud.spanner_dbapi. This is (1) and (2) in the description, I just wanted to make it explicit that we're using namespace packages here and this isn't just a directory move.

Both great changes, and both following the conventions of the other python repos.

c24t commented Sep 10, 2020

Copy link
Copy Markdown
Contributor

After talking to @skuruppu it sounds like we should keep the django-google-spanner distribution name:

Copy link
Copy Markdown

@mf2199, this PR looks not very actual - most part is already merged. Should we close it?

IlyaFaer commented Oct 6, 2020

Copy link
Copy Markdown

Closing as this PR seems to be old, and its changes were merged with other smaller PRs

IlyaFaer closed this Oct 6, 2020
IlyaFaer deleted the refactor branch February 1, 2021 08:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/python-spanner-django API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL