FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: add filesystem check to `test-fs-stat-date.mjs` by LiviaMedeiros · Pull Request #44174 · nodejs/node · GitHub

/ node Public

test: add filesystem check to test-fs-stat-date.mjs - #44174

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:port-44129-to-main
Aug 14, 2022
Merged

test: add filesystem check to test-fs-stat-date.mjs#44174
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
LiviaMedeiros:port-44129-to-main

Conversation

Copy link
Copy Markdown
Member

main-based alternative to: #44129

Skip the test if filesystem doesn't provide correct atime or mtime value from fs.stat().

LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 8, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022

This comment was marked as outdated.

aduh95 requested a review from richardlau August 8, 2022 15:01
richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 8, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Copy Markdown
Collaborator

LiviaMedeiros added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 9, 2022

github-actions Bot commented Aug 9, 2022

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @LiviaMedeiros. Please 👍 to approve.

Copy link
Copy Markdown
Member Author

Marking as fast-track PRs that do not need to wait for 48 hours to land. in case if we need this in v16.17.0 before deadlines.

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Aug 14, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 14, 2022
nodejs-github-bot merged commit 86276d3 into nodejs:main Aug 14, 2022

Copy link
Copy Markdown
Collaborator

Landed in 86276d3

danielleadams pushed a commit that referenced this pull request Aug 16, 2022
PR-URL: #44174
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
ruyadorno pushed a commit that referenced this pull request Aug 23, 2022
PR-URL: #44174
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Sep 5, 2022
PR-URL: #44174
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos commented Sep 16, 2022

Copy link
Copy Markdown
Member

Copy link
Copy Markdown
Member Author

According to #44129 (comment), this test platform uses NFS mounts.
According to RFC 1813, Page 21, NFSv3 uses unsigned types for timestamps:

      struct nfstime3 {
         uint32   seconds;
         uint32   nseconds;
      };

While NFSv4 (RFC 7530, Page 21) uses signed:

   struct nfstime4 {
           int64_t         seconds;
           uint32_t        nseconds;
   };

This is my best guess on why could this happen.

Opened #44707 against main, let me know if backport PR would be more convenient.

richardlau mentioned this pull request Oct 7, 2022

Copy link
Copy Markdown
Member

@LiviaMedeiros I cherry-picked #43714 and this commit to v16.x-staging but it doesn't seem to work as expected. See #44542 (comment) https://ci.nodejs.org/job/node-test-binary-arm-12+/15525/RUN_SUBSET=1,label=pi2-docker/testReport/junit/(root)/test/parallel_test_fs_stat_date/

This is causing the CI to fail in the v16.x release branch. I will label this as dont-land-on-v16.x; feel free to remove it if needed

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants


Back | FazBrowse Home | New Git URL