V16.18.0 proposal - #44886
Conversation
Sorry, something went wrong.
|
Review requested:
|
Sorry, something went wrong.
|
Hey! Sorry for the delay; as you may see, the branch-diff output was quite large. This proposal is failing in the "test-doc" job; due to #44477 not being part of this proposal and #44588 being included. This is the test-doc output: === release test-deprecation-codes ===
Path: doctool/test-deprecation-codes
node:internal/process/esm_loader:97
internalBinding('errors').triggerUncaughtException(
^
AssertionError [ERR_ASSERTION]: Ill-formed or out-of-order deprecation code.
at <anonymous> (/home/juanarbol/GitHub/node/doc/api/deprecations.md:3156:1)
at testHeading (file:///home/juanarbol/GitHub/node/tools/doc/deprecationCodes.mjs:27:12)
at file:///home/juanarbol/GitHub/node/tools/doc/deprecationCodes.mjs:87:5
at ModuleJob.run (node:internal/modules/esm/module_job:193:25)
at async Promise.all (index 0)
at async ESMLoader.import (node:internal/modules/esm/loader:526:24)
at async loadESM (node:internal/process/esm_loader:91:5)
at async handleMainPromise (node:internal/modules/run_main:65:12) {
generatedMessage: false,
code: 'ERR_ASSERTION',
actual: 'DEP0167: ',
expected: 'DEP0166: ',
operator: 'strictEqual'
}I have no idea what to do with this case. It would be fantastic if anyone can give me a picture or something! On the other hand, exceptional thanks to the back-porters! You all were faster than me in preparing the release (@MoLow, impressive); sadly, I postponed this release by three days, and I could not include all of them. |
Sorry, something went wrong.
|
I need to rebase to repair the linter; I will do that tomorrow. The changelog will be the same, it is just a cosmetic change and it will change almost all the commit SHAs :/ |
Sorry, something went wrong.
In the commit for #44588 that adds the DEP0167 deprecation amend doc/api/deprecations.md to skip the missing number: <!-- md-lint skip-deprecation DEP0166 --> (see the line for DEP0159 Line 3055 in 5fc9d3c Amending the commit will allow the tests to pass for that commit and avoids the tests being broken in one commit and then fixed up later. |
Sorry, something went wrong.
|
@juanarbol #44872 is good to be included (it fails CI for the same, unknown to me, reasons as this will). |
Sorry, something went wrong.
Notable changes: * doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588 * http: throw error on content-length mismatch (sidwebworks) #44378 * lib: add diagnostics channel for process and worker (theanarkh) #44045 * os: add machine method (theanarkh) #44416 * report: expose report public native apis (Chengzhong Wu) #44255 * src: expose environment RequestInterrupt api (Chengzhong Wu) #44362 * stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505 * util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576 PR-URL: #44886
That's what I did! Thank you! That fixes everything! |
Sorry, something went wrong.
|
Sorry, something went wrong.
|
parallel/test-net-socket-connect-without-cb and parallel/test-net-socket-ready-without-cb fail on v16.x-staging as well as all open, otherwise good to go, backport PRs not ok 2000 parallel/test-net-socket-ready-without-cb
---
duration_ms: 0.173
severity: fail
exitcode: 1
stack: |-
node:events:491
throw er; // Unhandled 'error' event
^
Error: connect EADDRNOTAVAIL ::1:35463 - Local (:::0)
at internalConnect (node:net:1041:16)
at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1197:9)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:111:8)
Emitted 'error' event on Socket instance at:
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21) {
errno: -99,
code: 'EADDRNOTAVAIL',
syscall: 'connect',
address: '::1',
port: 35463
}
...
not ok 1990 parallel/test-net-socket-connect-without-cb
---
duration_ms: 0.149
severity: fail
exitcode: 1
stack: |-
node:events:491
throw er; // Unhandled 'error' event
^
Error: connect EADDRNOTAVAIL ::1:45721 - Local (:::0)
at internalConnect (node:net:1041:16)
at defaultTriggerAsyncIdScope (node:internal/async_hooks:464:18)
at GetAddrInfoReqWrap.emitLookup [as callback] (node:net:1197:9)
at GetAddrInfoReqWrap.onlookup [as oncomplete] (node:dns:111:8)
Emitted 'error' event on Socket instance at:
at emitErrorNT (node:internal/streams/destroy:157:8)
at emitErrorCloseNT (node:internal/streams/destroy:122:3)
at processTicksAndRejections (node:internal/process/task_queues:83:21) {
errno: -99,
code: 'EADDRNOTAVAIL',
syscall: 'connect',
address: '::1',
port: 45721
}
...
|
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/47095/ Note: v8-CI is not required; there are no changes in v8 for this release. |
Sorry, something went wrong.
Sorry, something went wrong.
We run all WPT from one subset in the same process using workers. As the number of the tests grow, it can take longer to run some of the subsets, but it's still overall faster than running them in different processes. This patch increases the timeout for WPT to prevent the test from failing because it takes longer to run (even though it would still complete at some point). Refs: nodejs/reliability#371 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> PR-URL: #44574 Backport-PR-URL: #44872
Sorry, something went wrong.
Notable changes: assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) #44191 crypto: allow zero-length secret KeyObject (Filip Skokan) #44201 crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201 doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588 http: make idle http parser count configurable (theanarkh) #43974 http: throw error on content-length mismatch (sidwebworks) #44378 lib: add diagnostics channel for process and worker (theanarkh) #44045 net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) #44021 net: add local family (theanarkh) #43975 report: expose report public native apis (Chengzhong Wu) #44255 src: expose environment RequestInterrupt api (Chengzhong Wu) #44362 stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505 test_runner: add before/after/each hooks (Moshe Atlow) #43730 util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576 PR-URL: #44886
Sorry, something went wrong.
Notable changes: assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) #44191 crypto: allow zero-length secret KeyObject (Filip Skokan) #44201 crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) #44201 doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) #44588 http: make idle http parser count configurable (theanarkh) #43974 http: throw error on content-length mismatch (sidwebworks) #44378 lib: add diagnostics channel for process and worker (theanarkh) #44045 net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) #44021 net: add local family (theanarkh) #43975 report: expose report public native apis (Chengzhong Wu) #44255 src: expose environment RequestInterrupt api (Chengzhong Wu) #44362 stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) #44505 test_runner: add before/after/each hooks (Moshe Atlow) #43730 util: add `maxArrayLength` option to Set and Map (Kohei Ueno) #43576 PR-URL: #44886
Notable changes: assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) nodejs/node#44191 crypto: allow zero-length secret KeyObject (Filip Skokan) nodejs/node#44201 crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) nodejs/node#44201 doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) nodejs/node#44588 http: make idle http parser count configurable (theanarkh) nodejs/node#43974 http: throw error on content-length mismatch (sidwebworks) nodejs/node#44378 lib: add diagnostics channel for process and worker (theanarkh) nodejs/node#44045 net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) nodejs/node#44021 net: add local family (theanarkh) nodejs/node#43975 report: expose report public native apis (Chengzhong Wu) nodejs/node#44255 src: expose environment RequestInterrupt api (Chengzhong Wu) nodejs/node#44362 stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) nodejs/node#44505 test_runner: add before/after/each hooks (Moshe Atlow) nodejs/node#43730 util: add `maxArrayLength` option to Set and Map (Kohei Ueno) nodejs/node#43576 PR-URL: nodejs/node#44886
Notable changes: assert: add `getCalls` and `reset` to callTracker (Moshe Atlow) nodejs/node#44191 crypto: allow zero-length secret KeyObject (Filip Skokan) nodejs/node#44201 crypto: allow zero-length IKM in HKDF and in webcrypto PBKDF2 (Filip Skokan) nodejs/node#44201 doc: deprecate modp1, modp2, and modp5 groups (Tobias Nießen) nodejs/node#44588 http: make idle http parser count configurable (theanarkh) nodejs/node#43974 http: throw error on content-length mismatch (sidwebworks) nodejs/node#44378 lib: add diagnostics channel for process and worker (theanarkh) nodejs/node#44045 net,tls: pass a valid socket on `tlsClientError` (Daeyeon Jeong) nodejs/node#44021 net: add local family (theanarkh) nodejs/node#43975 report: expose report public native apis (Chengzhong Wu) nodejs/node#44255 src: expose environment RequestInterrupt api (Chengzhong Wu) nodejs/node#44362 stream: add `ReadableByteStream.tee()` (Daeyeon Jeong) nodejs/node#44505 test_runner: add before/after/each hooks (Moshe Atlow) nodejs/node#43730 util: add `maxArrayLength` option to Set and Map (Kohei Ueno) nodejs/node#43576 PR-URL: nodejs/node#44886
2022-10-12, Version 16.18.0 'Gallium' (LTS), @juanarbol
Notable changes
Commits