test: loosen test for negative timestamps in test-fs-stat-date - #44707
Merged
nodejs-github-bot merged 1 commit intoOct 7, 2022
Merged
test: loosen test for negative timestamps in test-fs-stat-date#44707nodejs-github-bot merged 1 commit into
nodejs-github-bot merged 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Sep 19, 2022
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@nodejs/testing @nodejs/fs |
Sorry, something went wrong.
jasnell
approved these changes
Oct 2, 2022
Merged
richardlau
approved these changes
Oct 7, 2022
juanarbol
pushed a commit
that referenced
this pull request
Oct 8, 2022
PR-URL: #44707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
PR-URL: #44707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One more attempt to make test from #43714 pass on v16.x-staging and avoid similar test failures on main in the future.
If filesystem doesn't support negative timestamps and stat returns 0, print a warning and proceed.
cc @targos