| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
CI: https://ci.nodejs.org/job/node-test-pull-request/51380/ note to look into https://ci.nodejs.org/job/node-test-commit-osx/51831/nodes=osx11-x64/ edit: I've stress tested wpt/test-timers in CI as well as locally and couldn't get a new hit on this failure. I'm not going to mark it as flaky now but if it resurfaces, since it's timers related marking it flaky in WPT would be the right course of action. edit2: Having had a look at the reliability reports, i'm going to open a separate PR to skip the flaky test (#47646) edit3: I'll move these the few WPTs from wpt/test-timers to test/sequential in a separate PR. #47657 |
Sorry, something went wrong.
Sorry, something went wrong.
Sorry, something went wrong.
PR-URL: #47635 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
|
@panva would you be able to backport this to v18.x-staging? |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
This PR reintroduces #47283 but with more refactoring done to the runner to get around the issue that caused it to get reverted in #47627.
The issue at hand was that upon test completion the worker gets intentionally terminated, the worker got terminated based on a Map<string, Worker> where the key is the filename. That was not a problem until concurrency got introduced which meant that the same file but with different query string variants which didn't affect the key were added to the Map. This has lead to some multi variant test workers to get terminated. I've fixed this issue with the refactors explained below and confirmed that it's fixed by comparing the number of individual executed tests to be the same as on main (and in record time).
ScreenshotI've refactored the runner as follows:
With this in place then
Additionally:
I will apply dont-land-* labels to observe the behaviour for a while before eventually landing this on Current by removing https://github.com/nodejs/node/labels/dont-land-on-v20%2Ex