FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: reduce WPT concurrency by panva · Pull Request #47834 · nodejs/node · GitHub

/ node Public

test: reduce WPT concurrency - #47834

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:lower-wpt-concurrency
May 5, 2023
ConversationCommits (1)ChecksFiles changed
Merged

test: reduce WPT concurrency#47834
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
panva:lower-wpt-concurrency

Conversation

panva commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Refs: #47657 (comment)

Because of the flaky wpt/test-timers and sometimes crashing wpt/test-webcrypto this PR

  • moves the WPT test suite back to SimpleTestConfiguration
  • reduces the default WPT files concurrency by 1 to save one CPU for the WPTRunner itself
  • introduces an option to force a given concurrency for a WPT Runner so that timing sensitive suites can be ran sequentially

cc @targos @tniessen

nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 3, 2023

panva commented May 3, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

Shall we also unskip negative-settimeout.any.js? refs: #37672

panva added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels May 3, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 3, 2023

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51597/

panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label May 3, 2023
panva mentioned this pull request May 3, 2023
Closed

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51600/

nodejs-github-bot commented May 3, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51602/

panva added the commit-queue Add this label to land a pull request using GitHub Actions. label May 3, 2023
github-actions Bot mentioned this pull request May 4, 2023
Open
28 tasks
mhdawson approved these changes May 4, 2023
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

github-actions Bot mentioned this pull request May 5, 2023
Open
22 tasks
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 5, 2023
nodejs-github-bot merged commit 3d00354 into nodejs:main May 5, 2023

nodejs-github-bot commented May 5, 2023

Copy link
Copy Markdown
Collaborator

Landed in 3d00354

panva deleted the lower-wpt-concurrency branch May 5, 2023 08:52
This was referenced May 6, 2023
Open
Open
Open
panva mentioned this pull request May 10, 2023
Merged
targos pushed a commit that referenced this pull request May 12, 2023
test: reduce WPT concurrency
54607bf 
PR-URL: #47834
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos mentioned this pull request May 15, 2023
Merged

danielleadams commented Jul 4, 2023

Copy link
Copy Markdown
Contributor

Blocked by #47635

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes
tniessen tniessen approved these changes
+2 more reviewers
targos targos approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL