FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: port flaky wpt/html/webappapis/timers tests to test/sequential by panva · Pull Request #47657 · nodejs/node · GitHub

/ node Public

test: port flaky wpt/html/webappapis/timers tests to test/sequential - #47657

Closed
panva wants to merge 1 commit into
nodejs:mainfrom
panva:move-flaky-wpt
ConversationCommits (1)ChecksFiles changed
Closed

test: port flaky wpt/html/webappapis/timers tests to test/sequential#47657
panva wants to merge 1 commit into
nodejs:mainfrom
panva:move-flaky-wpt

Conversation

panva commented Apr 21, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

wpt/test-timers has been unreliable since we've re-enabled parallel execution in WPTs. This PR removes the html/webappapis/timers WPTs and ports the tests to test/sequential instead.

e.g.
nodejs/reliability#548

panva added timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. test Issues and PRs related to the tests. labels Apr 21, 2023
panva mentioned this pull request Apr 21, 2023
Merged
nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 21, 2023

panva commented Apr 21, 2023

Copy link
Copy Markdown
Member Author

cc @nodejs/timers

panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 21, 2023

This comment was marked as outdated.

Sign in to view

This comment was marked as outdated.

Sign in to view

nodejs-github-bot commented Apr 21, 2023

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/51399/

panva added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Apr 22, 2023
This was referenced Apr 24, 2023
Open
Open

tniessen commented Apr 25, 2023

Copy link
Copy Markdown
Member

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

github-actions Bot mentioned this pull request Apr 26, 2023
Open
36 tasks

panva commented Apr 26, 2023

Copy link
Copy Markdown
Member Author

I understand the motivation, but is there an alternative, such as adding an option to run some WPTs sequentially or so?

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

panva added the review wanted PRs that need reviews. label Apr 26, 2023
github-actions Bot mentioned this pull request Apr 27, 2023
Open
35 tasks
panva added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Apr 27, 2023

panva commented May 3, 2023

Copy link
Copy Markdown
Member Author

ping @nodejs/timers

targos commented May 3, 2023

Copy link
Copy Markdown
Member

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

panva commented May 3, 2023

Copy link
Copy Markdown
Member Author

Not when the other WPT suites execute in parallel. The problem appears to be in used up resources, and with webcrypto hogging those up...

If we're already parallelizing WPT suites in the WPT runner, shouldn't we run test/wpt sequentially?

I'm just looking at nodejs/reliability and wpt/test-webcrypto also occasionally crashes. So i'm going to open a PR reverting the python side of things to sequential and also introducing maximum parallelism option in the WPTRunner.

panva mentioned this pull request May 3, 2023
Merged

panva commented May 3, 2023

Copy link
Copy Markdown
Member Author

Closing in favour of #47834

panva closed this May 3, 2023
panva deleted the move-flaky-wpt branch August 22, 2025 14:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anonrig anonrig approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. flaky-test Issues and PRs related to the tests with unstable failures on the CI. needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL