src: disable abseil deadlock detection by legendecas · Pull Request #57582 · nodejs/node · GitHub

Abseil deadlock detection is reporting false positives in tests in V8.
Abseil mutexes are not used in node core, so disable it for now.

Refs: nodejs/node-v8#301

Abseil deadlock detection is reporting false positives in tests. Disable it for now.

Review requested:

@nodejs/gyp
@nodejs/startup

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (8b2098f) to head (8193761).
Report is 328 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57582      +/-   ##
==========================================
- Coverage   90.22%   90.22%   -0.01%     
==========================================
  Files         630      630              
  Lines      185045   185055      +10     
  Branches    36243    36247       +4     
==========================================
+ Hits       166961   166963       +2     
- Misses      11034    11037       +3     
- Partials     7050     7055       +5

Files with missing lines	Coverage Δ
src/node.cc	73.55% <100.00%> (+0.03%)	⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Windows build error:

 abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: __cdecl absl::synchronization_internal::Win32Waiter::Win32Waiter(void)" (??0Win32Waiter@synchronization_internal@absl@@QEAA@XZ) referenced in function AbslInternalPerThreadSemInit [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: bool __cdecl absl::synchronization_internal::Win32Waiter::Wait(class absl::synchronization_internal::KernelTimeout)" (?Wait@Win32Waiter@synchronization_internal@absl@@QEAA_NVKernelTimeout@23@@Z) referenced in function AbslInternalPerThreadSemWait [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: void __cdecl absl::synchronization_internal::Win32Waiter::Post(void)" (?Post@Win32Waiter@synchronization_internal@absl@@QEAAXXZ) referenced in function AbslInternalPerThreadSemPost [D:\a\node\node\node_mksnapshot.vcxproj]
abseil.lib(per_thread_sem.obj) : error LNK2019: unresolved external symbol "public: void __cdecl absl::synchronization_internal::Win32Waiter::Poke(void)" (?Poke@Win32Waiter@synchronization_internal@absl@@QEAAXXZ) referenced in function "public: static void __cdecl absl::synchronization_internal::PerThreadSem::Tick(struct absl::base_internal::ThreadIdentity *)" (?Tick@PerThreadSem@synchronization_internal@absl@@SAXPEAUThreadIdentity@base_internal@3@@Z) [D:\a\node\node\node_mksnapshot.vcxproj]
out\Release\node_mksnapshot.exe : fatal error LNK1120: 4 unresolved externals [D:\a\node\node\node_mksnapshot.vcxproj]

Looks like we need this change from 3d1fe71#diff-7ec0a6942f03ad6ff24215a31b1b45a378ee21b2cba5f79937281c5f5528d2bf

CI: https://ci.nodejs.org/job/node-test-pull-request/65939/

Landed in 78af51c

Abseil deadlock detection is reporting false positives in tests. Disable it for now. PR-URL: #57582 Refs: nodejs/node-v8#301 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

This doesn't land cleanly on v22.x-staging, can you add it to #57982

Abseil deadlock detection is reporting false positives in tests. Disable it for now. PR-URL: nodejs#57582 Backport-PR-URL: nodejs#57982 Refs: nodejs/node-v8#301 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Abseil deadlock detection is reporting false positives in tests. Disable it for now. PR-URL: #57582 Backport-PR-URL: #57982 Refs: nodejs/node-v8#301 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

nodejs/node#57582

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

nodejs/node#57582

* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>

Disables standalone abseil.lib build on Windows by changing the abseil target type from 'static_library' to 'none'. This prevents LNK2005 linker errors where absl::Mutex::Dtor and other symbols are defined in both abseil.lib and v8_libbase.lib. Root cause: Node.js v24 extracted abseil to a separate build target (tools/v8_gypfiles/abseil.gyp) to share code between V8 and perfetto. On Windows with MSVC, this creates duplicate symbol errors because V8's libbase already includes the necessary abseil implementations. Solution: On Windows only, configure abseil as type 'none' so headers are available but no separate static library is built. V8's libbase continues to provide the abseil implementations it needs. Error: abseil.lib(abseil.mutex.obj) : error LNK2005: absl::Mutex::Dtor already defined in v8_libbase.lib(v8_libbase.mutex.obj) References: - nodejs/node#57289 (abseil extraction) - nodejs/node#57582 (abseil deadlock detection)

src: disable abseil deadlock detection

a5d3f79

Abseil deadlock detection is reporting false positives in tests. Disable it for now.

nodejs-github-bot added build Issues and PRs related to build files or the CI. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2025

anonrig approved these changes Mar 21, 2025

View reviewed changes

targos approved these changes Mar 21, 2025

View reviewed changes

This comment was marked as off-topic.

Sign in to view

jasnell approved these changes Mar 21, 2025

View reviewed changes

fixup! src: disable abseil deadlock detection

8193761

targos approved these changes Mar 21, 2025

View reviewed changes

targos mentioned this pull request Mar 22, 2025

[help wanted] deps: update V8 to 13.4 #57114

Closed

6 tasks

lpinca approved these changes Mar 22, 2025

View reviewed changes

RafaelGSS approved these changes Mar 23, 2025

View reviewed changes

StefanStojanovic approved these changes Mar 24, 2025

View reviewed changes

RaisinTen approved these changes Mar 24, 2025

View reviewed changes

targos added request-ci Add this label to start a Jenkins CI on a PR. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Apr 1, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 1, 2025

targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 2, 2025

nodejs-github-bot merged commit 78af51c into nodejs:main Apr 2, 2025

legendecas deleted the abseil-deadlock branch April 2, 2025 09:31

RafaelGSS mentioned this pull request May 1, 2025

2025-05-06, Version 24.0.0 (Current) #57609

Merged

aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025

aduh95 mentioned this pull request May 6, 2025

[v22.x backport] tools: extract target abseil to abseil.gyp #57982

Merged

github-actions Bot mentioned this pull request May 19, 2025

2025-05-21, Version 22.16.0 'Jod' (LTS) #58388

Merged

codebytere added a commit to electron/electron that referenced this pull request May 23, 2025

src: disable abseil deadlock detection

e76264f

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request May 26, 2025

src: disable abseil deadlock detection

e85ae3a

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request May 29, 2025

src: disable abseil deadlock detection

970d491

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request Jun 2, 2025

src: disable abseil deadlock detection

450f0e6

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: disable abseil deadlock detection

6992f4f

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: disable abseil deadlock detection

a187d20

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: disable abseil deadlock detection

a17f534

nodejs/node#57582

codebytere added a commit to electron/electron that referenced this pull request Jun 3, 2025

src: disable abseil deadlock detection

d3d57d3

nodejs/node#57582

ghost mentioned this pull request Jun 8, 2025

### Notable Changes autofix-ci/action#28

Closed

src: disable abseil deadlock detection by legendecas · Pull Request #57582 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: disable abseil deadlock detection - #57582

src: disable abseil deadlock detection#57582
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:abseil-deadlock

legendecas commented Mar 21, 2025 •
edited
Loading

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

This comment was marked as off-topic.

codecov Bot commented Mar 21, 2025 •
edited
Loading

Uh oh!

Uh oh!

targos commented Mar 21, 2025

Uh oh!

nodejs-github-bot commented Apr 1, 2025

Uh oh!

nodejs-github-bot commented Apr 2, 2025

Uh oh!

aduh95 commented May 6, 2025 •
edited
Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

src: disable abseil deadlock detection by legendecas · Pull Request #57582 · nodejs/node · GitHub

Uh oh!

Uh oh!

src: disable abseil deadlock detection - #57582

src: disable abseil deadlock detection#57582nodejs-github-bot merged 2 commits intonodejs:mainnodejs/node:mainfrom legendecas:abseil-deadlocklegendecas/node:abseil-deadlockCopy head branch name to clipboard

Conversation

legendecas commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Mar 21, 2025

Uh oh!

This comment was marked as off-topic.

codecov Bot commented Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

targos commented Mar 21, 2025

Uh oh!

nodejs-github-bot commented Apr 1, 2025

Uh oh!

nodejs-github-bot commented Apr 2, 2025

Uh oh!

aduh95 commented May 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

src: disable abseil deadlock detection#57582
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
legendecas:abseil-deadlock

legendecas commented Mar 21, 2025 •
edited
Loading

codecov Bot commented Mar 21, 2025 •
edited
Loading

aduh95 commented May 6, 2025 •
edited
Loading