src: improve thread safety of TaskQueue - #57910
Merged
nodejs-github-bot merged 1 commit intoApr 22, 2025
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
codebytere
force-pushed
the
mutex-flush-tasks
branch
from
cfdeed7 to
6b85518
Compare
April 17, 2025 12:50
Copy link
Copy Markdown
Codecov ReportAttention: Patch coverage is 97.56098% with 2 lines in your changes missing coverage. Please review.
@@ Coverage Diff @@
## main #57910 +/- ##
========================================
Coverage 90.25% 90.26%
========================================
Files 630 630
Lines 185691 186170 +479
Branches 36407 36480 +73
========================================
+ Hits 167589 168039 +450
+ Misses 10994 10975 -19
- Partials 7108 7156 +48
... and 65 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
bnoordhuis
reviewed
Apr 17, 2025
Comment thread
src/node_platform.h
Outdated
Comment thread
src/node_platform.h
Outdated
Comment thread
src/node_platform.cc
Outdated
Comment thread
src/node_platform.cc
Outdated
codebytere
force-pushed
the
mutex-flush-tasks
branch
2 times, most recently
from
0ffd2a4 to
f1b6765
Compare
April 17, 2025 17:47
Copy link
Copy Markdown
Member
|
@codebytere I wonder if this could also help with #54918. |
Sorry, something went wrong.
bnoordhuis
approved these changes
Apr 18, 2025
bnoordhuis
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with some suggestions.
Sorry, something went wrong.
Comment thread
src/node_platform.cc
Outdated
Comment thread
src/node_platform.cc
Outdated
Comment thread
src/node_platform.cc
Outdated
codebytere
force-pushed
the
mutex-flush-tasks
branch
2 times, most recently
from
0192c4f to
78a514e
Compare
April 19, 2025 10:42
mcollina
approved these changes
Apr 19, 2025
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
RSLGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Member
I applied this patch and unfortunately it does not. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Thanks for checking! |
Sorry, something went wrong.
jasnell
approved these changes
Apr 19, 2025
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
joyeecheung
approved these changes
Apr 21, 2025
joyeecheung
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM (as in, my tiny head can't find potential issues out of the new locks), though I think it can use a bit more comments (I am fairly certain that the race can only happen at shutdown, the platform is initialized too early for any tasks to be posted during that process)
Sorry, something went wrong.
Comment thread
src/node_platform.cc
Outdated
codebytere
force-pushed
the
mutex-flush-tasks
branch
from
78a514e to
d71a542
Compare
April 21, 2025 17:50
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #57910 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
PR-URL: #57910 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
PR-URL: #57910 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
PR-URL: #57910 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 23, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 26, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
May 29, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 2, 2025
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Jun 2, 2025
* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 3, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 4, 2025
* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
Copy link
Copy Markdown
Member
|
This commit requires a manual backport to land on v20.x |
Sorry, something went wrong.
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 6, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 18, 2025
codebytere
added a commit
to electron/electron
that referenced
this pull request
Jun 30, 2025
* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 * chore: fix out of date patch --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
kigh-ota
pushed a commit
to kigh-ota/electron
that referenced
this pull request
Sep 30, 2025
* chore: bump node in DEPS to v22.16.0 * crypto: remove BoringSSL dh-primes addition nodejs/node#57023 * tools: enable linter in test/fixtures/test\-runner/output nodejs/node#57698 * src: improve thread safety of TaskQueue nodejs/node#57910 * buffer: define global v8::CFunction objects as const nodejs/node#57676 * src: disable abseil deadlock detection nodejs/node#57582 * zlib: fix pointer alignment nodejs/node#57727 * chore: fixup patch indices * src: set default config as node.config.json nodejs/node#57171 * src: update std::vector<v8::Local<T>> to use v8::LocalVector<T> nodejs/node#57578 * test: disable chmod tests failing in Docker nodejs/node#58326 --------- Co-authored-by: electron-roller[bot] <84116207+electron-roller[bot]@users.noreply.github.com> Co-authored-by: Shelley Vohr <shelley.vohr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #56236.
Improve thread safety of TaskQueue by making locking of TaskQueue explicit and thus hopefully preventing a crash due to uv_async_send being called with nullptr.