FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: delete OpenSSL demos, doc and test folders by targos · Pull Request #57835 · nodejs/node · GitHub

/ node Public

deps: delete OpenSSL demos, doc and test folders - #57835

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-openssl-folders
Apr 13, 2025
Merged

deps: delete OpenSSL demos, doc and test folders#57835
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:rm-openssl-folders

Conversation

targos commented Apr 11, 2025

Copy link
Copy Markdown
Member

And ignore them for future updates.

And ignore them for future updates.

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency. labels Apr 11, 2025
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025

Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown
Collaborator

targos added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 12, 2025
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 13, 2025
nodejs-github-bot merged commit dfaded8 into nodejs:main Apr 13, 2025

Copy link
Copy Markdown
Collaborator

Landed in dfaded8

targos deleted the rm-openssl-folders branch April 13, 2025 16:29
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
And ignore them for future updates.

PR-URL: #57835
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. and removed dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels May 1, 2025

Copy link
Copy Markdown
Member

This needs to be reverted (#58099) to fix the OpenSSL update scripts which rely on being able to run parts of the OpenSSL configuration/build that errors if at least docs is missing. I've stuck dont-land labels to stop this being backported to releases (I think it may already be on the v24.x-staging branch/v24.0.0-proposal cc @RafaelGSS ).

RafaelGSS pushed a commit that referenced this pull request May 2, 2025
And ignore them for future updates.

PR-URL: #57835
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

shipujin commented Jul 31, 2025
edited
Loading

Copy link
Copy Markdown
Member

In the update openssl need "deps/openssl/openssl/test"

root@slackwareloong:/node# make -C deps/openssl/config  clean
make: Entering directory '/node/deps/openssl/config'
find archs \( -name \*.S -o -name \*.s -o -name \*.asm -o \
-name \*.gypi -o -name \*.h -o -name \*.pm -o -name \*.rc \) -exec rm "{}" \;
make: Leaving directory '/node/deps/openssl/config'
root@slackwareloong:/node# make -C deps/openssl/config  
make: Entering directory '/node/deps/openssl/config'
cd ../openssl; CONFIGURE_CHECKER_WARN=1 CC=gcc perl ./Configure no-comp no-shared no-afalgeng enable-ssl-trace enable-fips aix64-gcc-as;
Configuring OpenSSL version 3.5.1 for target aix64-gcc-as
Using os-specific seed configuration

Failure!  Makefile wasn't produced.
Please read INSTALL.md and associated NOTES-* files.  You may also have to
look over your available compiler tool chain or change your configuration.

Something went wrong with /node/deps/openssl/openssl/test/build.info: No such file or directory
make: *** [Makefile:56: aix64-gcc-as] Error 2
make: Leaving directory '/node/deps/openssl/config'

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. dependencies Pull requests that update a dependency file. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. needs-ci PRs that need a full CI run. openssl Issues and PRs related to the OpenSSL dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL